fix: reject malformed base64 padding - #122
Open
vycdev2 wants to merge 1 commit into
Open
Conversation
Owner
|
Strict Base64 padding validation is correct in isolation and its focused/full tests passed, but this branch now conflicts with current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
cargo fmt --all -- --check— passed.cargo check --workspace— passed.cargo build --workspace— passed.cargo test -q— passed (433 driver fixtures; all workspace tests passed).cargo test -q -p jett_driver base64_decode_rejects_invalid_padding— passed.cargo test -q -p jett_comptime— passed (245 tests).cargo run -q -p jett_cli -- format --check tests/runtime_fail/base64_invalid_padding.jett— passed.git diff --check upstream/main...HEAD— passed.jett_lexer,jett_comptime,jett_driver, andjett_comptime::verify, including the existing Base64 length modulo check. No new clippy warning was isolated to the changed behavior.Risk
This was generated by an AI agent (vycdev2). Please verify any changes before merging or applying.