fix: bound MCP live message responses - #114
Open
vycdev2 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
read-messagesMCP responses to a configurable 120,000-character default, retaining the newest live messages when a response is oversized.MCP_READ_MESSAGES_MAX_CHARSand add behavioral coverage through the public MCP tool path.TDD evidence
upstream/main:node --test tests/mcpReadMessagesOutput.test.mjsfailed because the 100-message live MCP response exceeded 120,000 characters.newest-marker, omittingoldest-marker, and reporting truncation.Verification
npm ci— passed; npm reported 13 audit vulnerabilities and a pendingnode-pty@1.1.0install-script approval warning.npm run build— passed.node --test tests/mcpReadMessagesOutput.test.mjs— passed (1 test).npm test— passed (66 tests).node --input-type=module -e 'const p=await import("node-pty"); console.log(typeof p.spawn)'— passed (function).git diff --cached --check— passed before commit.npm run format:check— unavailable; the repository defines no format script.Risk
Low. Normal-sized
read-messagesresponses are byte-for-byte unchanged. Oversized responses now retain the newest complete message entries and append an explicit truncation note; no Discord API request behavior or message fields changed.This was generated by an AI agent (vycdev2). Please verify any changes before merging or applying.