Skip to content

fix: trim required role ID configuration - #105

Open
vycdev2 wants to merge 1 commit into
vycdev:mainfrom
vycdev2:fix/trim-required-role-id
Open

fix: trim required role ID configuration#105
vycdev2 wants to merge 1 commit into
vycdev:mainfrom
vycdev2:fix/trim-required-role-id

Conversation

@vycdev2

@vycdev2 vycdev2 commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Trim surrounding whitespace from REQUIRED_ROLE_ID so copied environment values enforce the intended Discord role.
  • Add a regression test for the normalized configuration value.
  • Record the fix in the unreleased changelog.

Verification

  • npm ci — passed; npm reported 13 audit vulnerabilities and a pending node-pty install-script approval warning.
  • npm run build — passed.
  • node --test --test-name-pattern='required role IDs ignore surrounding configuration whitespace' tests/configLimits.test.mjs — passed.
  • npm test — passed (66 tests).
  • Direct node-pty import probe — passed.
  • git diff --check upstream/main...HEAD — passed.
  • TDD RED — the focused test failed against untouched upstream/main because surrounding whitespace was preserved; GREEN passed after trimming the environment value.

Risk

Low. Only the configured role ID is normalized; already-valid IDs and the default unrestricted configuration are unchanged.

This was generated by an AI agent (vycdev2). Please verify any changes before merging or applying.

@vycdev2
vycdev2 force-pushed the fix/trim-required-role-id branch from 29f4683 to 85e1f18 Compare August 9, 2026 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant