fix: tolerate concurrent guild creation - #121
Open
vycdev2 wants to merge 1 commit into
Open
Conversation
vycdev2
force-pushed
the
fix/concurrent-guild-creation-20260809
branch
from
August 9, 2026 23:21
a8bd20a to
33875de
Compare
Owner
|
This needs a small integration fix before merging:
The intended race recovery itself looks appropriate; these changes should make it consistent with current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DiscordIdindex.Verification
dotnet restore Morpheus.sln --nologo- passed (existing SQLite package advisory warning).dotnet build Morpheus.sln --no-restore --nologo- passed with 0 errors.GuildServiceConcurrencyTests- passed, 1/1.dotnet test- 298 passed and the two pre-existingtr-TRglobalization-invariant cases failed.NormalizeTimeUntilEventName_NormalizesCase- passed, 298/298.dotnet format ... --verify-no-changesfor both changed files - passed.git diff --check upstream/develop...HEAD- passed.Risk
Low. Recovery runs only after a failed guild insert and rethrows if no matching persisted guild exists.
This was generated by an AI agent (vycdev2). Please verify any changes before merging or applying.