Skip to content

fix: validate emoji import selection ids - #113

Open
vycdev2 wants to merge 1 commit into
vycdev:developfrom
vycdev2:fix/validate-emoji-selection-ids
Open

fix: validate emoji import selection ids#113
vycdev2 wants to merge 1 commit into
vycdev:developfrom
vycdev2:fix/validate-emoji-selection-ids

Conversation

@vycdev2

@vycdev2 vycdev2 commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Validate emoji import select-menu IDs before parsing them.
  • Return an ephemeral error for malformed server or emoji selections instead of allowing the interaction handler to throw.
  • Add focused coverage for valid, missing, signed, non-decimal, and overflowing IDs.

Verification

  • dotnet restore Morpheus.sln — passed (existing NU1903 SQLite vulnerability warning).
  • dotnet build Morpheus.sln --no-restore — passed.
  • dotnet test Morpheus.Tests/Morpheus.Tests.csproj --no-build --filter FullyQualifiedName~EmojisModuleTests — passed (10 tests).
  • Full test suite — 305 passed, 2 failed because the environment is globalization-invariant and has no ICU package for the existing Turkish-culture tests.
  • git diff --check — passed.

Risk

  • Low: only malformed interaction payload handling changes; valid decimal Discord IDs retain existing behavior.

This was generated by an AI agent (vycdev2). Please verify any changes before merging or applying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant