Conversation
A generic argument such as computed<Foo>(...) only requires the getter's return value to be assignable to Foo. Because TypeScript does not run excess property checks when inferring into a generic, returning an object with extra properties is silently allowed. Add a tip to the Typing computed() section showing the loose generic behavior, the stricter return-type-annotation alternative, and the satisfies operator as a concise way to enforce an exact shape. close vuejs#3286
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A generic argument such as
computed<Foo>(...)only checks that the getter's return value is assignable toFoo. Because TypeScript does not run excess property checks when inferring into a generic, returning an object with extra properties is silently allowed — which can surprise users who expect strict shape checking.This adds a tip to the "Typing
computed()" section showing:satisfiesoperator as a concise way to enforce an exact shapeclose #3286