Repository navigation
Reject unencrypted file content by default when E2EE is enabled - #218
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes E2EE-enabled CouchDB receivers reject documents containing unencrypted file content by default. The previous plaintext acceptance behaviour remains available through an explicit opt-in.
The default applies to ordinary replication, direct reads, and Fast Fetch. Integrations that intentionally accept plaintext can set
acceptUnencryptedContenttotrue; outgoing content remains encrypted. The setting participates in settings transfer and the existing settings lifecycle.On-demand Chunk retrieval also rejects responses which are not valid Chunk documents, and diagnostics omit rejected document bodies. This does not authenticate all file metadata or repair content already stored locally.
Prepares Commonlib 0.4.3 with release notes and reporter acknowledgement.
Validation:
npm run verify:package: type checks, 3,767 unit tests, boundary and release tests, and packed-package checks.npm run test:integration:managed: 40 tests.The package has not yet been published to npm; registry artefact verification remains part of publication.