Repository navigation
fix: recover unapplied logical deletions during ordinary scans - #215
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix lets an opted-in host recover received logical deletions during an ordinary scan while preserving files whose unchanged contents cannot be established.
Related to vrtmrz/obsidian-livesync#1338. A deletion may reach the database while its Vault file remains present; the existing ordinary scan did not retry that reflection.
Behaviour and cost
Verification
Physical iPhone performance and Android-specific timestamp precision remain unmeasured. External edits after the final observation are outside the non-transactional storage guarantee. The initial iPhone reflection failure reported in the issue has not been reproduced; this change supplies the guarded recovery path.
The package is not yet published. The consumer will need an immutable published version before release.