Skip to content

fix: adapt openviking backend to options api - #1151

Merged
yaozheng-fang merged 2 commits into
volcengine:mainfrom
xgtcode:fix/openviking-sdk-options
Sep 28, 2026
Merged

yaozheng-fang merged 2 commits into
volcengine:mainfrom
xgtcode:fix/openviking-sdk-options

Conversation

@xgtcode

@xgtcode xgtcode commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Adapt OpenViking backends to openviking-sdk>=0.1.9 options-style APIs.
  • Move OpenViking find/search/create_session/add_resource optional parameters into options.
  • Stop passing legacy top-level session to OpenViking context search.
  • Raise the declared openviking-sdk dependency lower bound from >=0.1.3 to >=0.1.9.
  • Strengthen OpenViking unit tests with fake clients that match the new SDK signatures.

Details

openviking-sdk>=0.1.9 changed several APIs from top-level optional parameters to an options object. This PR updates VeADK's OpenViking integrations accordingly:

  • Long-term memory:

    • create_session(..., options={"memory_policy": ...})
    • find(..., options={"context_type": "memory"})
  • KnowledgeBase:

    • find/search(..., options={score_threshold, filter, context_type, tags, telemetry})
    • add_resource(..., options={strict, include, exclude, reason, instruction, telemetry, ...})
    • search now only passes session_id, not legacy session

Validation

  • uv run pre-commit run --files pyproject.toml uv.lock veadk/memory/long_term_memory_backends/openviking_backend.py veadk/knowledgebase/backends/openviking_backend.py tests/test_openviking_long_term_memory.py tests/test_openviking_knowledgebase.py
  • uv run pytest tests/test_openviking_long_term_memory.py tests/test_openviking_knowledgebase.py

Result:

62 passed

@yaozheng-fang
yaozheng-fang merged commit 31d2c67 into volcengine:main Sep 28, 2026
16 checks passed
PolarisCzh pushed a commit to PolarisCzh/veadk-python that referenced this pull request Sep 29, 2026
* fix: adapt openviking backend to options api

* test: stabilize codex inactivity timeout test

Co-authored-by: TRAE CLI <traecli@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants