Repository navigation
fix: adapt openviking backend to options api - #1151
Merged
yaozheng-fang merged 2 commits intoSep 28, 2026
Merged
Conversation
yaozheng-fang
approved these changes
Sep 28, 2026
PolarisCzh
pushed a commit
to PolarisCzh/veadk-python
that referenced
this pull request
Sep 29, 2026
* fix: adapt openviking backend to options api * test: stabilize codex inactivity timeout test Co-authored-by: TRAE CLI <traecli@bytedance.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openviking-sdk>=0.1.9options-style APIs.find/search/create_session/add_resourceoptional parameters intooptions.sessionto OpenViking context search.openviking-sdkdependency lower bound from>=0.1.3to>=0.1.9.Details
openviking-sdk>=0.1.9changed several APIs from top-level optional parameters to anoptionsobject. This PR updates VeADK's OpenViking integrations accordingly:Long-term memory:
create_session(..., options={"memory_policy": ...})find(..., options={"context_type": "memory"})KnowledgeBase:
find/search(..., options={score_threshold, filter, context_type, tags, telemetry})add_resource(..., options={strict, include, exclude, reason, instruction, telemetry, ...})searchnow only passessession_id, not legacysessionValidation
uv run pre-commit run --files pyproject.toml uv.lock veadk/memory/long_term_memory_backends/openviking_backend.py veadk/knowledgebase/backends/openviking_backend.py tests/test_openviking_long_term_memory.py tests/test_openviking_knowledgebase.pyuv run pytest tests/test_openviking_long_term_memory.py tests/test_openviking_knowledgebase.pyResult: