Repository navigation
fix(skills): clean up bash process groups on timeout and cancellation - #1146
Merged
Merged
Conversation
warm-wm
approved these changes
Sep 22, 2026
PolarisCzh
pushed a commit
to PolarisCzh/veadk-python
that referenced
this pull request
Sep 29, 2026
…volcengine#1146) Co-authored-by: TRAE CLI <traecli@bytedance.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
bash_tool(command="sleep 900 | cat", timeout=5, ...)kills only the outer shell on timeout. The pipeline children retain the output pipes, so the subsequent unboundedprocess.wait()can prevent the tool from returning its timeout error.Start commands in a separate session on POSIX and kill their process group on timeout or cancellation, including when the shell has already exited. Retain ownership when cancellation arrives during process creation. Limit cleanup waits to 5 seconds and close local transports if descendants still hold the pipes open. Preserve the tool signature, output formatting, timeout error, and cancellation propagation; non-POSIX systems retain direct-process termination.
The regression tests verify the original pipeline command returns a timeout error, its children stop, and the next call outputs
TOOL_TIMEOUT_RECOVERED. They also cover cancellation during execution and spawning, an already-exited shell, cleanup deadlines, process-exit races, spawn failures, and normal output compatibility. Process-group cleanup does not claim to terminate descendants that explicitly detach into another session.Validation:
tests/tools/test_skills_bash_tool.py,tests/tools/test_skills_session_path.py, andtests/skills.