Skip to content

fix: pin mcp[cli]<2 to avoid mcp-types 2.x TypedDict extra_items erro… - #441

Merged
cuericlee merged 1 commit into
volcengine:mainfrom
hooncp:fix-mcp-version-extra_items
Oct 12, 2026
Merged

cuericlee merged 1 commit into
volcengine:mainfrom
hooncp:fix-mcp-version-extra_items

Conversation

@hooncp

@hooncp hooncp commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Root cause

server/mcp_server_bytehouse/pyproject.toml declares mcp[cli]>=1.12.0 with no upper bound, so uvx resolves to mcp==2.3.0 / mcp-types==2.3.0, which is incompatible with the Python 3.12 FaaS runtime.

Change

  • Constrain the dependency to the v1 line: mcp[cli]>=1.12.0,<2.

@hooncp
hooncp force-pushed the fix-mcp-version-extra_items branch 4 times, most recently from 451d4cd to 24a0900 Compare October 12, 2026 03:23
@hooncp
hooncp force-pushed the fix-mcp-version-extra_items branch from 24a0900 to 437c204 Compare October 12, 2026 03:25

@cuericlee cuericlee left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
变更内容(现在只有 2 处核心改动 + 对应 lock)
pyproject.toml
版本 0.2.0 → 0.2.1(patch 级,符合"仅加依赖上限"的改动性质)
mcp[cli]>=1.12.0 → mcp[cli]>=1.12.0,<2
uv.lock
mcp-bytehouse 版本 0.1.0 → 0.2.1
requires-dist 中 mcp specifier 同步改为 >=1.12.0,<2
上次问题的解决情况
✅ 版本不一致已修复
pyproject.toml: 0.2.1
uv.lock: 0.2.1 ← 已同步,一致

✅ 巨型 lockfile 噪声已消除
上一版还带着 revision 1→3 的全量 upload-time 元数据刷新(40 多万字符),这版 diff 只剩 5 个 hunk 的实际改动,干净很多——看起来是按仓库固定的 uv 版本重新生成的 lock,没有引入格式迁移噪声。
顺带说明(不阻塞)
base 分支上本身存在一个存量问题:lock 是 0.1.0 而 pyproject 是 0.2.0。这次 PR 把两边统一到 0.2.1,等于顺手修掉了这个预存的不一致,是正向的。
版本号从 patch 级入手(而不是上次的 0.3.0 minor)更合理,0.x 阶段小改动建议走 patch 递增。
结论
✅ 批准合入。依赖上限、lock 一致性、diff 干净度都没问题了。

@cuericlee
cuericlee merged commit 81b4471 into volcengine:main Oct 12, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants