Repository navigation
fix: pin mcp[cli]<2 to avoid mcp-types 2.x TypedDict extra_items erro… - #441
Merged
Merged
Conversation
hooncp
force-pushed
the
fix-mcp-version-extra_items
branch
4 times, most recently
from
October 12, 2026 03:23
451d4cd to
24a0900
Compare
hooncp
force-pushed
the
fix-mcp-version-extra_items
branch
from
October 12, 2026 03:25
24a0900 to
437c204
Compare
cuericlee
approved these changes
Oct 12, 2026
cuericlee
left a comment
Collaborator
There was a problem hiding this comment.
/lgtm
变更内容(现在只有 2 处核心改动 + 对应 lock)
pyproject.toml
版本 0.2.0 → 0.2.1(patch 级,符合"仅加依赖上限"的改动性质)
mcp[cli]>=1.12.0 → mcp[cli]>=1.12.0,<2
uv.lock
mcp-bytehouse 版本 0.1.0 → 0.2.1
requires-dist 中 mcp specifier 同步改为 >=1.12.0,<2
上次问题的解决情况
✅ 版本不一致已修复
pyproject.toml: 0.2.1
uv.lock: 0.2.1 ← 已同步,一致
✅ 巨型 lockfile 噪声已消除
上一版还带着 revision 1→3 的全量 upload-time 元数据刷新(40 多万字符),这版 diff 只剩 5 个 hunk 的实际改动,干净很多——看起来是按仓库固定的 uv 版本重新生成的 lock,没有引入格式迁移噪声。
顺带说明(不阻塞)
base 分支上本身存在一个存量问题:lock 是 0.1.0 而 pyproject 是 0.2.0。这次 PR 把两边统一到 0.2.1,等于顺手修掉了这个预存的不一致,是正向的。
版本号从 patch 级入手(而不是上次的 0.3.0 minor)更合理,0.x 阶段小改动建议走 patch 递增。
结论
✅ 批准合入。依赖上限、lock 一致性、diff 干净度都没问题了。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
server/mcp_server_bytehouse/pyproject.tomldeclaresmcp[cli]>=1.12.0with no upper bound, souvxresolves tomcp==2.3.0/mcp-types==2.3.0, which is incompatible with the Python 3.12 FaaS runtime.Change
mcp[cli]>=1.12.0,<2.