Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
OpenViking's real Hermes plugin installation check runs only in the Ubuntu activation job. The Windows Quick Local job copies the plugin directly, so it cannot detect failures in
hermes plugins installon a fresh destination. NousResearch/hermes-agent#139533 reported this exact Windows installer path.This PR adds a Windows install-only smoke to the existing platform matrix. It uses the Hermes commit that fixed fresh-destination installation, runs the real installer, compares the installed plugin with the checked-out source, and uploads the installation evidence. Plugin activation remains in the existing POSIX job because it requires
pty.Human Involvement
Related Issue
Type of Change
Changes Made
bb706e92c775b6a16765b3249a6fdd0427e7430c.Testing
Validated locally with:
ruff 0.15.5 format --check scripts/check-hermes-plugin-install.pyruff 0.15.5 check scripts/check-hermes-plugin-install.pyactionlint 1.7.7 .github/workflows/hermes-plugin-tests.ymlpython3 -m py_compile scripts/check-hermes-plugin-install.pygit diff --checkmypy 1.19.1 scripts/check-hermes-plugin-install.pystill reports the existingsys._base_executableattribute error on the unchanged activation path.Checklist
Screenshots (if applicable)
Not applicable.
Additional Notes
The first Windows CI run completed the real installation and exposed a CRLF-sensitive byte comparison in the checker. The follow-up uses UTF-8 text equality. The Windows CI job remains the authoritative native-platform validation.