Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hermes
viking_rememberdirectly interpolated exceptions into message and commit failure responses. An exception such as an emptyTimeoutError()therefore produced an error with no diagnostic detail.This change preserves nonempty exception messages and falls back to the exception type when the message is empty. Existing failure-stage, acceptance-state, session URI, recovery command, and retry guidance remain unchanged.
Human Involvement
Related Issue
Related external report: vectorize-io/hindsight#5634
Type of Change
Changes Made
Testing
Validation used the Hermes commit pinned by the repository workflow (
7951ddd7297a284d6da48804241ee05a8a0c621c) with retries disabled.test_standalone.py: 82 passed.python -m py_compilepassed for both changed files.ruff check --ignore I001,B018passed for both changed files. The ignored rules are existing unrelated findings in these legacy files.git diff --checkpassed.Checklist
No documentation change is needed because the public tool contract and recovery instructions are unchanged. No dependent change is required.
Screenshots (if applicable)
Not applicable.
Additional Notes
The change is limited to the two
viking_rememberexception branches. Shared HTTP error formatting and retry behavior are unchanged.