Skip to content

fix(vlm): default affected GPT tool calls to no reasoning #6137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qin-ctx merged 1 commit into from
Oct 15, 2026
Merged

fix(vlm): default affected GPT tool calls to no reasoning #6137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions openviking/models/vlm/backends/openai_vlm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,9 @@ def _apply_completion_params(
max_tokens_param = "max_tokens"
kwargs["temperature"] = self.temperature

if kwargs.get("tools") and self.provider != "openai-codex":
if re.match(r"gpt-(?:5\.[456]|6-(?:sol|luna))(?:-|$)", kwargs["model"].lower()):
kwargs["reasoning_effort"] = "none"
effective_max_tokens = max_tokens if max_tokens is not None else self.max_tokens
if effective_max_tokens is not None:
kwargs[max_tokens_param] = effective_max_tokens
Expand Down Expand Up @@ -288,10 +291,10 @@ def _build_text_kwargs(
"model": model,
"messages": kwargs_messages,
}
self._apply_completion_params(kwargs, effective_thinking, max_tokens=max_tokens)
if tools:
kwargs["tools"] = tools
kwargs["tool_choice"] = tool_choice or "auto"
self._apply_completion_params(kwargs, effective_thinking, max_tokens=max_tokens)
return kwargs

def _build_vision_kwargs(
Expand Down Expand Up @@ -319,10 +322,10 @@ def _build_vision_kwargs(
"model": model,
"messages": kwargs_messages,
}
self._apply_completion_params(kwargs, effective_thinking)
if tools:
kwargs["tools"] = tools
kwargs["tool_choice"] = tool_choice or "auto"
self._apply_completion_params(kwargs, effective_thinking)
return kwargs

def _extract_completion_content(self, response, elapsed: float) -> str:
Expand Down
Loading