Repository navigation
Conversation
cocolord
marked this pull request as draft
October 15, 2026 08:40
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to merged PR #5268, which made Volcengine AK/SK scalar-query and delete errors propagate for all callers. Restore the original default behavior and add internal
VikingFS.rm(..., raise_on_error=True)for TTL callers that need to observe those request failures. The option defaults to false and is passed explicitly through the existing URI deletion, adapter and collection calls; no public HTTP, SDK, CLI or MCP option is added.The opt-in covers both ID enumeration and delete requests, reusing the existing HTTP/JSON error handling. Other backends retain their contracts. An accepted deletion request is sufficient: no synchronous index count, residue checks, extra locks or stored fields are added. TTL failure registration and retry scheduling remain outside this change.
Validation
VikingFS.rm→ vector backend → adapter → Volcengine request path. Its 16 combinations cover default/opt-in behavior, scalar-query/delete failures (HTTP 429, HTTP 500, invalid JSON), accepted requests, repeated deletion of absent files, and retaining files on opt-in failure. Ordinary scalar queries and delete-all retain their defaults after opt-in calls.ec56b9443),uv run --no-sync pytest -q -o addopts= tests/storage/test_volcengine_clients.py tests/misc/test_vikingfs_uri_guard.py tests/storage/test_transfer_merge_binding.py -k 'volcengine or http or uri or transfer_uses_queries_without_count_or_sort or rm_cloud_errors_are_opt_in': 106 passed, including all 16 new combinations and 90 existing related cases.git diff --check. Targeted mypy with--follow-imports=silentreports the same 234 existing diagnostics as the merge-base snapshot, with no added or removed diagnostics; it is not green. The added regression has no type errors. Validation used the existing uv environment.Human Involvement