Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
viking_storecurrently saves the Python representation of a role/content text-block list, so a normal LangChain message becomes[{...}]in the session. Extract its text with the existing shared helper, matching equivalent string messages and the history converter.Human Involvement
Related Issue
Fixes #6063
Type of Change
Changes Made
extract_message_text()for list-valued role/content messages inviking_store.parts, role mapping and tool-result attribution.Testing
On original tested main
f047d805, the new regressions have 4 text-block failures and 10 normal controls; with the fix, all 14 pass. The scoped LangChain suites have 237 passed / 1 SQLite skip on Linux, and 235 passed / 1 skip / 2 resource-path failures on Windows. The same two Windows failures occur on the base, which has 231 passed / 1 skip / 6 failures including the four new regressions. Both Windows runs report 68 warnings.Ruff check/format (44 files), mypy (15 source files), wheel/sdist build, Twine, offline target installation and the installed optional-dependency smoke pass. Three installed public producer/tool controls and one scalar control pass; the 15 wheel source files match the committed and installed code. These selections overlap and are not added together.
Checklist
Screenshots (if applicable)
Not applicable.
Additional Notes
Validation uses cached dependencies and the official deterministic client fixture with LangChain's real public message producer. It does not cover a fresh dependency lock, a base-only environment, a deployed backend, full server, model, authentication, performance or a minimum-version matrix.
The existing adapter and shared extractor remain the work of their upstream authors. #5808 concerns Responses text-block type recognition, #5854 generic ChatMessage roles, #6036 retriever metadata references, and #6017 package relocation; this change only connects already-supported ordinary text-block extraction to the explicit store tool.
The commit is rebased onto main
f2b09cd1c4a857aa621cbae91677d9b31cc4fd34. The 54 actually loaded tracked files, related package inputs and contribution/template files are byte-equivalent to the original tested scope; the two changed files retain their exact tested bytes. The new head also passes the 14 formal regressions. The Windows/Linux and package results above keep their original execution scope and times; the complete new server tree was not retested.A later main snapshot
ae1e45e0053988d093cca0bea10fe8d44281871ahas a clean read-only merge and retains the tested LangChain/SDK/package inputs. This preserves the tested patch and review scope; no complete merged-server test is claimed.