Repository navigation
[Bug]: CLI cp file test creates a directory and keeps integration CI red #4662
Description
现象
06. API & CLI Integration Tests 从 f6d9dec6b（#4185）开始在 main 持续失败。Ubuntu 和 macOS 的失败一致：
tests/cli/test_cli_filesystem.py::TestFsCp::test_cp_file_json_and_human_output
FAILED_PRECONDITION: Cannot copy directory without --recursive: .../cp_source_*.txt
该轮 CLI 结果为 1 failed、44 passed、1 skipped；API tests 正常通过。
根因
测试通过 ov_add_resource(temp_path, source) 准备源文件，但 add-resource --to 创建的是 resource root。即使 URI 以 .txt 结尾，它仍是一个目录，真正导入的文件位于目录内部。
随后测试对这个 resource root 执行非递归 ov cp。服务端 stat 得到 isDir=true，按设计返回 FAILED_PRECONDITION。因此这里是测试数据构造错误，不是文件复制实现把普通文件误判成目录。
为什么合入前没有拦住
#4185 自身的 fork CI 没有模型 secrets，相关认证错误被测试框架转换成 skip；该轮显示 25 passed、21 skipped，因此新增用例没有真正覆盖成功路径。
建议修复
- 用
ov write <source> --content "copy me" --mode create --wait创建真正的文件，再执行非递归ov cp。 - 不要给当前调用补
-r，否则测试会退化成目录复制，仍然没有覆盖 file-copy。 - 在 Ubuntu 和 macOS 上重跑 CLI integration tests，确认该用例不再被 skip。
证据
- 首个失败的 main run：https://github.com/volcengine/OpenViking/actions/runs/33717802992
- 后续同签名失败：https://github.com/volcengine/OpenViking/actions/runs/33742547413
- feat: 增加事务化文件系统复制能力 #4185 合入 commit：f6d9dec
- feat: 增加事务化文件系统复制能力 #4185 的 fork CI：https://github.com/volcengine/OpenViking/actions/runs/33603911300
Activity
now-ing commentedon Sep 3, 2026
Took this one — the fix is up in #4672: the test now creates a real file with
ov write --mode create(the conftestov_writehelper already passes--wait --timeout), keeps the non-recursive form so file-copy coverage is preserved (no-r), and drops the now-unneeded local temp file. Also confirmedcreateis the right server-side write mode (openviking/storage/content_write.py), same call shape astests/cli/test_cli_snapshot.py.now-ing commentedon Sep 6, 2026
Verified fixed on current main: 94a1031 (merged 2026-09-04 via #4589) rewrote
test_cp_file_json_and_human_outputto copy the existingtest_file_urifixture (a real file inside the pack) instead ofov_add_resourceon a temp.txtpath, so the non-recursive file-copy path is covered again instead of hitting theisDir=trueFAILED_PRECONDITION. The06. API & CLI Integration Testsjob is green on main at 0c5147c (run 34003645461) after being red since f6d9dec. Closing #4672 was the right call — superseded by the fixture rewrite above. This looks closable; happy to reopen if the same signature reappears.now-ing commentedon Sep 6, 2026
This looks fixed on current
mainand can probably be closed:ov_add_resourcecreating a directory source for the non-recursiveov cpfile test) is gone — fix: watch task status #4589 (94a11313b) rewrotetest_cp_file_json_and_human_outputto take its source from thetest_file_urifixture, which resolves to a real file inside a pack, so the FAILED_PRECONDITION path no longer exists intests/cli/test_cli_filesystem.py.continue-on-erroraggregation from the API & CLI job, so if the test were still broken the job would be red. Recent runs on the current base (e.g. the API & CLI job on feat(parse): support task-based MinerU APIs and the online batch service #4725, based on post-fix: watch task status #4589 main) are green with the rewritten test in place.I had #4672 open with a different fix for the same test and closed it as superseded by the upstream rewrite — details there if useful.
qin-ctx commentedon Sep 18, 2026
感谢提交这个 issue。#4589 已将
test_cp_file_json_and_human_output改为使用test_file_uri提供的真实文件，不再通过单个 txt 导入得到一个目录，再拿它测试非递归文件复制。因此原来的Cannot copy directory without --recursive失败原因已经消除，文件复制的测试目标也保留了。按已修复关闭。如果当前 main 再出现同一失败，可以 reopen，或留言请求重新打开，并附上提交号、CI 运行链接和该测试的错误输出。