Repository navigation
test: make island CSS rewrite tests cross-platform - #73
Merged
Brooooooklyn merged 3 commits intoApr 3, 2026
Merged
Conversation
shulaoda
marked this pull request as draft
April 3, 2026 05:38
shulaoda
changed the title
shulaoda
marked this pull request as ready for review
April 3, 2026 05:56
Brooooooklyn
deleted the
04-03-fix_make_island_css_rewrite_tests_cross-platform
branch
April 3, 2026 06:33
cpojer
added a commit
that referenced
this pull request
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the 3 failing tests on Windows CI (actions/runs/23934859867).
Summary
island-css-rewriteunit tests failing onwindows-latestCI due to hardcoded POSIX absolute paths in assertionspath.resolve("/project/...")prepends the current drive letter (e.g.D:/project/...), causing the 3 relative-to-absolute CSS rewrite assertions to mismatchp()helper that normalizes test paths throughresolve+normalizePath, so expectations are platform-correct on both Unix and Windows without changing the source implementationTest plan
pnpm test packages/void/test/unit/island-css-rewrite.test.ts— all 6 tests pass on Windows