Repository navigation
chore: Switch to publish to @void-sdk on GitHub during the private beta. - #59
Merged
Merged
Conversation
cpojer
force-pushed
the
void-sdk-publish
branch
2 times, most recently
from
April 1, 2026 08:55
4ac34ce to
0414855
Compare
cpojer
marked this pull request as ready for review
April 1, 2026 08:56
cpojer
force-pushed
the
void-sdk-publish
branch
2 times, most recently
from
April 1, 2026 09:17
6429791 to
d315151
Compare
cpojer
pushed a commit
that referenced
this pull request
Sep 11, 2026
The admin OAuth login flow generated a nonce in the HMAC-signed state but never stored or consumed it in the database, unlike the main auth flow which uses storeOAuthNonce/consumeOAuthNonce for single-use enforcement. An intercepted callback URL could be replayed within the OAuth code lifetime. Mirror the main auth flow by persisting the nonce in PostgreSQL and consuming it atomically on callback. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Touches OAuth login/callback handling for both admin and main auth routes; mistakes could break sign-in or incorrectly reject valid callbacks. Changes are security-motivated but affect a critical authentication path. > > **Overview** > Strengthens OAuth login integrity by **persisting and single-use consuming** the `nonce` during the *admin* Google OAuth flow, preventing replay of intercepted `/admin/callback` URLs. > > Adds a browser-binding check by setting an `oauth_nonce` cookie on login redirect and verifying it on callback (then clearing it) for both `/admin/*` and `/auth/*` flows, and updates integration tests to include the required cookie header. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 39e8e1454520526e96bc77649762ab6bb17b7b96. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.