Repository navigation
fix(deploy): pass cf --sql and --message as single argv values - #570
Open
davidgustys wants to merge 1 commit into
Open
davidgustys wants to merge 1 commit into
davidgustys wants to merge 1 commit into
Conversation
`cf d1 query --sql <value>` read SQL that starts with a comment (`-- ...`) as a flag, so seed files with a leading comment failed. Pass `--sql=<value>` and `--message=<value>` as one argument each so a value that starts with "-" is never parsed as an option.
davidgustys
force-pushed
the
fix/cf-single-argv-values
branch
from
October 23, 2026 13:05
68fa552 to
898ae59
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
void db execute --remote --file <file>fails when the file starts with a--comment. Void passes the SQL tocf d1 queryas two argv items,--sqland the SQL itself, so cf reads SQL that starts with-as another flag and stops withUnknown argument: leading comment.To reproduce, in a project with a remote D1 database:
The SQL and the version upload and deploy messages are now passed as one argv item each (
--sql=<sql>,--message=<message>), so a leading-stays part of the value. Void's own deploy messages start withvoid:today; the message change keeps those call sites consistent.cloudflare-operation-process.test.ts. It fails onmainwithUnknown argument: leading commentand passes with the fix.cf-version-runner.test.tsis updated for the new argv shape.vp run check,vp fmt,vp lintandvp run test --base main. The only failing files in the affected run are theinit,init-installandnitrotests, which fail the same way onmainlocally.