Repository navigation
fix: use --filter= syntax for cross-platform pnpm filter commands - #57
Merged
Brooooooklyn merged 1 commit intoApr 1, 2026
Conversation
Brooooooklyn
approved these changes
Apr 1, 2026
Brooooooklyn
deleted the
04-01-fix_use_--filter_syntax_for_cross-platform_pnpm_filter_commands
branch
April 1, 2026 01:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Single-quoted globs in pnpm filter (e.g.
pnpm -F './packages/**') break on Windows because cmd and PowerShell do not interpret single quotes as string delimiters.Two cross-platform alternatives:
pnpm -F \"./packages/**\"— escaped double quotes work everywhere, but look awkward and require extra escaping inside package.json scripts.pnpm --filter=./packages/**— the = form passes the value directly to pnpm without shell expansion, so no quotes are needed at all.Chose option 2 for simplicity and readability.