Repository navigation
fix(platform): align piped build logs in GitHub checks - #563
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://fix-github-check-output-void-cloud.voidzero-docs.workers.dev (commit 5e68781)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub check logs accumulated horizontal indentation after every Unix newline, turning dependency lists and deploy output into a staircase (reported check). Build children write to pipes, so their LF delimiters need carriage-return/newline semantics when replayed into the check renderer.
Render captured LF delimiters as CRLF and keep plain LF-delimited logs on the text fast path. Preserve raw captured delimiters, intentional indentation, ANSI parser state, and bare-CR progress rewrites. Regressions exercise the real build-agent capture → Markdown path with LF/CRLF, split chunks, colors, progress updates, and deployment boxes, plus a 100-line plain tail exceeding the terminal input budget.
Validation:
vp run check: all 33 workspace tasks passed; changed-file formatting and lint passed.vp run test --listandvp run test: 4,425 tests passed. Socket/browser tests were blocked by sandbox permissions; one unrelated Zero Trust timeout passed when rerun alone.vp test run --bail 1: full-suite selection attempted once, stopped on Chromium launch/socket permission failures.vp run build:allalso encountered sandbox-denied loopback sockets during prerendering.