Repository navigation
fix: normalize path separators in deploy packaging for Windows - #56
Merged
Brooooooklyn merged 2 commits intoApr 1, 2026
Conversation
Brooooooklyn
approved these changes
Apr 1, 2026
Brooooooklyn
deleted the
03-31-fix_normalize_path_separators_in_deploy_packaging_for_windows
branch
April 1, 2026 01:13
cpojer
pushed a commit
that referenced
this pull request
Sep 11, 2026
…tion (#56) The deploymentId query parameter on GET /projects/:id/logs was interpolated directly into an Analytics Engine SQL query without validation, allowing an authenticated user to inject SQL and read logs from other projects. Validate against the expected dpl_[0-9a-z]{12} format before interpolation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **High Risk** > Touches security-sensitive log querying by adding input validation to a value interpolated into an Analytics Engine SQL string; a mistake could still allow injection or break legitimate filtering. > > **Overview** > Prevents SQL injection in `GET /projects/:id/logs` by validating the optional `deploymentId` query param before interpolating it into the Analytics Engine SQL filter. > > Also tightens project `slug` validation to explicitly disallow leading/trailing dashes while still allowing single-character slugs. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 0cb4a1e82dfcd4b2c9c0b35cd00ab98356cb28db. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #55
In
packages/void/src/cli/package.ts,path.relative()is used to compute relative paths forformData.append(). On Windows,path.relative()returns paths with\separators (e.g.assets\defer-Dwmo8Go0-NWzFqTKN.js), but the Vite-generatedindex.jsuses/in its import statements. The path should be normalized to forward slashes before uploading.