Repository navigation
fix(ci): align staging asset cache smoke expectations - #555
Merged
cpojer merged 2 commits intoOct 23, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Trunk CI is broken now.
Staging smoke tests still require
no-storefor Access-protected hashed assets, but #552 intentionally preservesprivate, max-age=31536000, immutable. Requireprivateandimmutablefor protected assets, continue rejecting conflicting cache directives, and align the manual smoke-test instructions.Fix
Fixes the asset-cache assertion in the staging smoke run.
Verification
Validation: all 89 existing focused auth/cache/smoke tests passed, all 33 workspace typecheck tasks passed, and formatting and lint checks passed.
Unfortunately the failing workflow doesn't run on PRs so this can't be verified on CI until merge.