Repository navigation
fix: update Node runtimes for CVE-2026-111497 - #544
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://fix-node-cve-2026-111497-void-cloud.voidzero-docs.workers.dev (commit 3011418)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3011418fa9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cpojer
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Void's shipped default Sandbox still uses Node 26.10.0, and the GitHub build-agent image uses the floating
node:26-slimtag. Upgrade the maintained runtime pins to the fixed versions listed in the October 2026 Node security release for CVE-2026-111497..node-versionto 24.22.1, which is already consumed by the CI setup and release workflows.Package compatibility ranges, dependency versions and the lockfile are unchanged. Platform CI already uses
docker build --pull; there are no additional static cached Node image references to update.Validation
vp install --frozen-lockfile: passed, including the core package build.vp run test --list: selected all 731 files because.node-versionchanged; that selection was covered by the full verification below.vp run test:all: formatting, lint, all package/playground builds, artifact checks, platform type-aware lint andvp run checkpassed.--pull --platform linux/amd64. Inspection containers reported Node v26.12.1 and Debian 13 (trixie). The Sandbox helper was executable and a harmless Brotli round trip passed. The build agent retained Corepack 0.35.0, Bun 1.3.14, builder uid 1000 and its packaged agent entry; pnpm 11.8.0 and Yarn 1.22.22 ran offline as the unprivileged builder.git diff --check: passed.The full test suite did not pass: 728 files passed, 2 failed and 1 skipped; 14,262 tests passed, 2 failed and 31 skipped. The overall
vp run test:allexit code was 1.platform/packages/api/test/integration/admin-dashboard.test.ts:491: the ResizeObserver sizes array remained empty untilexpect.polltimed out. The entire file passed on a focused rerun.packages/void/test/integration/astro.test.ts: the initial SSR fetch lost its loopback connection. On the focused rerun, the dev cases passed but the PostgreSQL suite failed inbeforeAllat line 297: Astro restarted after dependency optimization/tsconfig reload, and Miniflare/Cloudflare Vite plugin type discovery lost a loopback socket (Server stopped while waiting,other side closed). The same PostgreSQL startup failure was reproduced with the original Node 24.21.0, confirmed with bothnode --versionandvp exec node --version. The fixed 24.22.1 pin was restored afterward. No application or test-source changes were made to hide these failures.This PR prepares the source fix. Existing published packages and running containers still require their normal release/rebuild/rollout before their runtime exposure is remediated.