Repository navigation
fix(create-void): validate Cloudflare-compatible project names - #541
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://fix-create-void-cloudflare-project-name-validation-void-cloud.voidzero-docs.workers.dev (commit 99ee307)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
Signed-off-by: Christoph Nakazawa <christoph.pojer@gmail.com>
cpojer
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lowercase check added in #513 still accepts names such as
my_app,my.app,my app, paths, and names longer than a workers.dev DNS label. The scaffolder writes the supplied name directly into package.json, so these inputs should receive actionable validation before files are created or dependencies installed.Extend the validator already shared by the interactive prompt and positional CLI argument to require lowercase ASCII letters, digits, and dashes, with an alphanumeric first/last character and a maximum of 63 characters. Preserve lowercase diagnostics and the interactive default. Add regression coverage for invalid characters, paths, Unicode/control characters, dash boundaries, single-character names, and the 63/64-character boundary; document the accepted project-name format.
Cloudflare references:
This narrows scaffold inputs: paths (including
.) and scoped names are rejected because the input is also used as the package name. Existing project deployment naming and the separately validated Void platform slug remain unchanged.Validation: five dependency-free Node test groups against the production validator/parser passed, covering valid/invalid input tables, boundaries, defaults, and existing argument forwarding. The repository Vite+ tests, affected-test checks, typecheck, and full suite could not run because
vpis unavailable and the shell proxy is unreachable, preventing dependency installation.