Repository navigation
fix(deploy): emit additional modules in framework Worker bundles - #537
Closed
Pleasurecruise wants to merge 2 commits into
Closed
Pleasurecruise wants to merge 2 commits into
Pleasurecruise wants to merge 2 commits into
Conversation
Pleasurecruise
added a commit
to Pleasurecruise/my-memos
that referenced
this pull request
Oct 21, 2026
Backports voidzero-dev/void#537 until it is released.
Pleasurecruise
added a commit
to Pleasurecruise/my-memos
that referenced
this pull request
Oct 21, 2026
- Replace wrangler.json/void.json with void.config.ts and void.lock.json - Move SQL migrations to apps/memos/db/migrations and apply them with `void db migrate`; drop the cf-config script and the direct wrangler dependency - Deploy with `void deploy --platform cloudflare`, including Workers Builds; manage secrets with `void secret` - Use the SvelteKit adapter's _worker.js as the Worker entry and drop worker.ts - Patch void 1.1.12 to keep Wasm, text and data imports as Worker modules, backporting voidzero-dev/void#537 until it is released - Upgrade void to 1.1.12, vite-plus to 1.3.0, SvelteKit 3.1 and other outdated deps - Render `---` under text as a thematic break by disabling setext headings
Pleasurecruise
added a commit
to Pleasurecruise/my-memos
that referenced
this pull request
Oct 21, 2026
- Replace wrangler.json/void.json with void.config.ts and void.lock.json - Move SQL migrations to apps/memos/db/migrations and apply them with `void db migrate`; drop the cf-config script and the direct wrangler dependency - Deploy with `void deploy --platform cloudflare`, including Workers Builds; manage secrets with `void secret` - Set preview_urls to false so Void can republish the existing Worker's traffic settings - Use the SvelteKit adapter's _worker.js as the Worker entry and drop worker.ts - Patch void 1.1.12 to keep Wasm, text and data imports as Worker modules, backporting voidzero-dev/void#537 until it is released - Upgrade void to 1.1.12, vite-plus to 1.3.0, SvelteKit 3.1 and other outdated deps - Render `---` under text as a thematic break by disabling setext headings
Pleasurecruise
added a commit
to Pleasurecruise/my-memos
that referenced
this pull request
Oct 21, 2026
- Replace wrangler.json/void.json with void.config.ts and void.lock.json - Move SQL migrations to apps/memos/db/migrations and apply them with `void db migrate`; drop the cf-config script and the direct wrangler dependency - Deploy with `void deploy --platform cloudflare`, including Workers Builds; manage secrets with `void secret` - Set preview_urls to false so Void can republish the existing Worker's traffic settings - Use the SvelteKit adapter's _worker.js as the Worker entry and drop worker.ts - Patch void 1.1.12 to keep Wasm, text and data imports as Worker modules (backports voidzero-dev/void#537) and to resolve packages with workerd conditions when it re-bundles the Worker - Upgrade void to 1.1.12, vite-plus to 1.3.0, SvelteKit 3.1 and other outdated deps - Render `---` under text as a thematic break by disabling setext headings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prepareBundledBuildOutputre-bundles framework Worker output with a plain Vite lib build, so.wasm,.bin,.txt,.htmland.sqlimports were bundled as JavaScript. This adds a plugin that mirrors@cloudflare/vite-plugin's additional modules: same rules, resolves#subpath imports, keeps matches external, and emits each file inrenderChunkwith a chunk-relative path.copyBundlethen uploads them with their existing module types.The Cloudflare plugin does not export this logic, so it is reimplemented here. It applies to every bundle built by
prepareBundledBuildOutput, including the static Worker, where it is a no-op.Test
#subpath import and a dynamic import becomewasm/text/datamodules and passcfdry-run. Fails without the fix.vp test run packages/void/test/unit/cf-build-output.test.tsandvp run --filter ./packages/void typecheckpass.@resvg/resvg-wasm.