Repository navigation
fix(pages): deferred props, action responses and dev rescan errors - #517
Merged
Merged
Conversation
- Dev: a page scan error during a rescan is logged and the last good scan
is kept, instead of an unhandled rejection that stops the dev server.
- A deferred group resolves only its own keys: a one-key group takes the
raw value, a larger group takes each key from the object. A value whose
object has a key named like another deferred prop no longer lands there.
- Prefetch and prerender payloads send a failed deferred group as an error
that the client rejects, instead of a silent null.
- A deferred resolver that returns undefined resolves to null on client
navigation, as it already did on a full page load.
- After an action, a loader that returns a redirect or error Response
answers with that Response, as on a GET, instead of rendering {} props.
- Only a withValidator issues body in a 400 becomes field errors. Other
400 responses from an action pass through unchanged.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Member
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://fix-pages-ssr-batch-void-cloud.voidzero-docs.workers.dev (commit b82fcfa)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes six bugs in Pages SSR: deferred props, action responses, and dev rescans.
layout: docsbefore_layouts/docs.*exists)void devexitsnull, baked into_void/pages/*.jsondeferredErrors, and the client rejects that prop as it does when streamingundefined, on client navigationnull, as on a full page load{}propswithValidatorissuesbody becomes field errorsHow
The deferred rule is the one the server's prefetch path and the docs ("Grouped Deferred Props") already use.
Tests
pages-client,pages-protocol, the newpages-islands-rescan, and the react/vue/svelte/solidplugin-pagestests. All 17 fail onmain.🤖 Generated with Claude Code