Repository navigation
test(platform): skip real sleeps in teardown and GitHub retry tests - #447
Merged
Merged
Conversation
Four teardown tests waited for the 2-second orphan-sweep pause, and the GitHub check-run, installation-token and webhook-delivery tests waited on 250 ms retry backoffs. They now skip only those delays and still check the same behavior. The six files take about 6 s instead of about 20 s. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://test-skip-real-sleeps-void-cloud.voidzero-docs.workers.dev (commit 6da3c29)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Some platform tests sleep for real on delays that the code under test owns:
A probe that wrapped
setTimeoutduring a full platform run found these waits. They add about 13 s of test time and check nothing.What this PR changes
skipOrphanSweepDelay()helper. Six files already use it. It zeroes only the 2 s delay. ThecfFetch60 s abort timer keeps its real delay, so it cannot fire early.beforeEachhooks. Each file'safterEachalready restores the spy.api-check-runs.test.tsis not changed:BuildManagerhas its own guard timers.Every test still checks the same attempt counts and outcomes.
unit/check-run.test.tsunit/installation-token.test.tsunit/webhook-deliveries.test.tsintegration/zero-trust-uninstall.test.tsintegration/email-shared-recipients.test.tsintegration/managed-durable-objects.test.tsTesting
vp run testvp run check🤖 Generated with Claude Code