Skip to content

ci: upgrade npm before the npm Prepublish Test - #438

Merged
Brooooooklyn merged 1 commit into
mainfrom
ci/prepublish-upgrade-npm
Oct 15, 2026
Merged

Brooooooklyn merged 1 commit into
mainfrom
ci/prepublish-upgrade-npm

Conversation

@Brooooooklyn

Copy link
Copy Markdown
Member

Problem

The npm leg of Prepublish Test fails on every pull request since 2026-10-15 14:51 UTC. Clean main fails the same way.

void → @cloudflare/workers-auth   optional peer vitest ^4.1.0
vite-plus 1.2.0 → vitest 5.0.4    out of that range
npm picks vitest 4.1.12 (published 14:51 UTC)
  → its peer @vitest/browser-webdriverio 4.1.11 needs vitest exactly 4.1.11
npm 11.19.x (bundled with Node 24.21) → TypeError: Cannot read properties of null (reading 'children')

npm 11.20 and later install the same packages without the crash.

Change

The npm leg runs npm i -g npm after setup-vp, and prints the version. The pnpm leg does not change. This does not pin a version.

Testing

Check Result
This PR changes prepublish-test.yml, so the scope step runs the prepublish suite see the Prepublish Test (ubuntu-latest, npm) check on this PR

🤖 Generated with Claude Code

https://claude.ai/code/session_0123r5HnanmW2VUrZ7VWDufH

npm 11.19.x, which Node 24.21 bundles, crashes on a fresh Vite+ and npm
install since vitest 4.1.12 was published ("Cannot read properties of
null (reading 'children')"). Newer npm installs the same packages.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0123r5HnanmW2VUrZ7VWDufH
@Brooooooklyn
Brooooooklyn requested a review from a team as a code owner October 15, 2026 16:22

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 95be74c845

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/prepublish-test.yml
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T16:24:48.225912Z 95be74c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Brooooooklyn
Brooooooklyn merged commit 134a2ee into main Oct 15, 2026
13 checks passed
@Brooooooklyn
Brooooooklyn deleted the ci/prepublish-upgrade-npm branch October 15, 2026 16:32

@examplessdk-lgtm examplessdk-lgtm left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants