Repository navigation
test: give heavy wrapper tests a Windows timeout budget - #436
Merged
Merged
Conversation
The "generateWrapper with migrations" tests bundle Workers and start workerd. On Windows CI runners they can stall on disk and process start and pass the 20-second unit timeout. Give that describe a 60-second budget on Windows only. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0123r5HnanmW2VUrZ7VWDufH
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://fix-flaky-wrapper-windows-timeouts-void-cloud.voidzero-docs.workers.dev (commit 56bebf3)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The tests in
generateWrapper with migrationsbundle Workers and start workerd through Miniflare. Many also start PGlite or a fake MySQL server. On Windows CI runners, disk and process start can stall. Then one of these tests can pass the 20-second unit timeout that Windows uses.Slowest test in this file, 16 Windows unit runs on
main(2026-10-14 to 2026-10-15):In that failed run, the file took 82.6 s and a neighbor test took 15.9 s. In 6 of 16 runs the slowest test took 8 s or more.
PR #435 (run 38700489787) also failed in this describe:
bundles the mysql2 dependencies that sit in the app node_modulespassed 20 s. Onmainit takes 0.7-2.3 s. In that period, unrelated tests on the same runner were 3-10x slower too.Per test on
main(16 runs):All tests that reach 8 s or more are in this describe. Tests in other describes of this file stay under 1 s on
main.Decisions
timeouton thegenerateWrapper with migrationsdescribevite.config.tsor the globaltestTimeoutKnown limits
beforeAllhook that prepares PGlite keeps its own 30 s Windows budget.Testing
vp test run packages/void/test/unit/wrapper.test.ts(macOS)undefinedvp lint --no-ignoreon the filevp fmtcheck on the filetest: windowsadded🤖 Generated with Claude Code
https://claude.ai/code/session_0123r5HnanmW2VUrZ7VWDufH