Repository navigation
test(void): run PGlite initdb once for the wrapper migration tests - #432
Merged
Merged
Conversation
Each new PGlite runs initdb. On Linux CI that took most of the 5s test deadline, and the pg bundle test timed out at 5108ms. Run initdb once in a hook with its own budget, and load each test's fresh database from the saved data directory. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0123r5HnanmW2VUrZ7VWDufH
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://fix-flaky-wrapper-pg-bundle-void-cloud.voidzero-docs.workers.dev (commit 53669b0)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
wrapper.test.ts > generateWrapper with migrations > bundles the pg dependencies that sit in the app node_modulestimed out on Linux CI (job): 5108 ms against the 5 s test deadline of theunit-pgliteproject.Each
new PGlite()runs initdb. That is about 0.7 s locally and 4–5× that on CI, and every PostgreSQL test in this block paid it inside its own deadline:Fix
Same pattern as #431: pay the one-time cost in a hook with its own budget.
Each test still gets its own fresh PGlite instance, so isolation does not change. No test deadline changes.
Result (local,
--project unit-pglite, same file)Under heavy local load (load average 40–88), the pg bundle test went from 1656–2891 ms to 511–635 ms.
🤖 Generated with Claude Code
https://claude.ai/code/session_0123r5HnanmW2VUrZ7VWDufH