Repository navigation
fix(email): convert email-validator for installed Void worker runtimes in dev - #407
Merged
Merged
Conversation
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://fix-email-validator-worker-dev-void-cloud.voidzero-docs.workers.dev (commit ac91636)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
This was referenced Oct 12, 2026
Closed
The full packed suite runs the email route under `vite preview` too. The built Worker has no dev inbox and no send binding there, so sendEmail returns BINDING_MISSING. Assert that instead of ok, and return the whole result so a failure shows its reason. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Brooooooklyn
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
vp dev, importingvoid/emailcrashes withReferenceError: exports is not defined, and the crash takes down every page, not just the email route.That's because Void excludes itself from the worker dep optimizer, so its CommonJS dependency
email-validatorreaches workerd without conversion.If Void owns the workerd runtime (no framework, TanStack Start, React Router, vinext), it now adds
include: ['void > email-validator'].Note: This might be also the case with hyperdrive and mysql2, but I couldnt repro this yet.