chore: remove dead code, slop, over tests and comment noise before open source

.github/scripts/postgres-concurrency-tests.ts

@@ -2,7 +2,7 @@ import { spawnSync } from 'node:child_process';
 import { readFileSync } from 'node:fs';
 // eslint-disable-next-line no-restricted-imports -- Native filesystem paths are never embedded in source.
 import { join } from 'node:path';
-import { fileURLToPath, pathToFileURL } from 'node:url';
+import { fileURLToPath } from 'node:url';
 import { parseSync } from 'vite';
 import { isRecord } from '../../packages/deploy-core/src/is-record.ts';
 import { compatibilityTestFiles } from './schema-compat-tests.ts';
@@ -38,7 +38,7 @@ function usesPostgresEnvironment(node: unknown): boolean {
 }
 
 /** Select real PostgreSQL cases without repeating the whole in-memory API suite. */
-export function postgresConcurrencyTestFiles(root: string): Array<string> {
+function postgresConcurrencyTestFiles(root: string): Array<string> {
   const files = compatibilityTestFiles(root).filter((file) => {
     const parsed = parseSync(file, readFileSync(join(root, file), 'utf8'));
     if (parsed.errors.length > 0) {
@@ -52,16 +52,14 @@ export function postgresConcurrencyTestFiles(root: string): Array<string> {
   return files;
 }
 
-if (process.argv[1] && pathToFileURL(process.argv[1]).href === import.meta.url) {
-  const files = postgresConcurrencyTestFiles(process.cwd());
-  // Reuse the bounded runner's independent database clones and cleanup for every file.
-  const result = spawnSync(
-    process.execPath,
-    [fileURLToPath(new URL('./schema-compat-tests.ts', import.meta.url)), ...files],
-    { stdio: 'inherit' },
-  );
-  if (result.error) {
-    throw result.error;
-  }
-  process.exitCode = result.status ?? 1;
+const files = postgresConcurrencyTestFiles(process.cwd());
+// Reuse the bounded runner's independent database clones and cleanup for every file.
+const result = spawnSync(
+  process.execPath,
+  [fileURLToPath(new URL('./schema-compat-tests.ts', import.meta.url)), ...files],
+  { stdio: 'inherit' },
+);
+if (result.error) {
+  throw result.error;
 }
+process.exitCode = result.status ?? 1;

.github/scripts/production-baseline.ts

@@ -1,12 +1,10 @@
 import { appendFileSync } from 'node:fs';
-import { pathToFileURL } from 'node:url';
 
-export async function productionBaseline(options: {
+async function productionBaseline(options: {
   configuredSha?: string;
   repository: string;
   token?: string;
-  environment?: string;
-  request?: typeof fetch;
+  environment: string;
 }): Promise<string> {
   if (options.configuredSha) {
     if (options.configuredSha.length !== 40 || !/^[0-9a-f]{40}$/i.test(options.configuredSha)) {
@@ -21,11 +19,10 @@ export async function productionBaseline(options: {
       'Provide a GitHub repository and read token, or set VOID_PLATFORM_PRODUCTION_REF to the deployed SHA.',
     );
   }
-  const request = options.request ?? fetch;
   const signal = AbortSignal.timeout(60_000);
-  const environment = options.environment ?? 'Prod';
+  const { environment } = options;
   const get = async (path: string): Promise<unknown> => {
-    const response = await request(`https://api.github.com/repos/${options.repository}/${path}`, {
+    const response = await fetch(`https://api.github.com/repos/${options.repository}/${path}`, {
       headers: {
         Accept: 'application/vnd.github+json',
         Authorization: `Bearer ${options.token}`,
@@ -70,15 +67,13 @@ export async function productionBaseline(options: {
   );
 }
 
-if (process.argv[1] && pathToFileURL(process.argv[1]).href === import.meta.url) {
-  const sha = await productionBaseline({
-    configuredSha: process.env.PRODUCTION_REF,
-    repository: process.env.GITHUB_REPOSITORY ?? '',
-    token: process.env.GITHUB_TOKEN,
-    environment: process.env.PRODUCTION_ENVIRONMENT || 'Prod',
-  });
-  if (process.env.GITHUB_OUTPUT) {
-    appendFileSync(process.env.GITHUB_OUTPUT, `sha=${sha}\n`);
-  }
-  console.log(`Previous production runtime: ${sha}`);
+const sha = await productionBaseline({
+  configuredSha: process.env.PRODUCTION_REF,
+  repository: process.env.GITHUB_REPOSITORY ?? '',
+  token: process.env.GITHUB_TOKEN,
+  environment: process.env.PRODUCTION_ENVIRONMENT || 'Prod',
+});
+if (process.env.GITHUB_OUTPUT) {
+  appendFileSync(process.env.GITHUB_OUTPUT, `sha=${sha}\n`);
 }
+console.log(`Previous production runtime: ${sha}`);

.github/scripts/schema-compat-tests.ts

@@ -7,9 +7,9 @@ import { createRequire } from 'node:module';
 import { join, relative, resolve } from 'node:path';
 import { pathToFileURL } from 'node:url';
 
-export const legacyZoneFixture = `      const second = await createTestProject(env.db, user.id, 'concurrent-zone-second');
+const legacyZoneFixture = `      const second = await createTestProject(env.db, user.id, 'concurrent-zone-second');
       stubCustomerCf({ zones });`;
-export const correctedZoneFixture = `      const second = await createTestProject(env.db, user.id, 'concurrent-zone-second');
+const correctedZoneFixture = `      const second = await createTestProject(env.db, user.id, 'concurrent-zone-second');
       const mx: Record<string, Array<string>> = {
         'concurrent-one.example.com': [],
         'concurrent-two.example.com': [],
@@ -32,13 +32,13 @@ export const correctedZoneFixture = `      const second = await createTestProjec
         },
       });`;
 
-export const legacyZoneProvision = `      await runEmailOperation(env.db, bindings(), accepted.value.operationId);`;
-export const correctedZoneProvision = `      provisionedDomain = (await env.db.select().from(emailDomainRoutes))[0]!.domain;
+const legacyZoneProvision = `      await runEmailOperation(env.db, bindings(), accepted.value.operationId);`;
+const correctedZoneProvision = `      provisionedDomain = (await env.db.select().from(emailDomainRoutes))[0]!.domain;
       await runEmailOperation(env.db, bindings(), accepted.value.operationId);`;
 
-export const legacyDeployBodyFixture = `    expect(res.status).not.toBe(413);
+const legacyDeployBodyFixture = `    expect(res.status).not.toBe(413);
   });`;
-export const correctedDeployBodyFixture = `    expect(res.status).not.toBe(413);
+const correctedDeployBodyFixture = `    expect(res.status).not.toBe(413);
     // Finish the deployment's database work before the next fixture resets its tables.
     await res.text();
   });`;
@@ -63,7 +63,7 @@ function correctKnownFixture(
 }
 
 /** Correct only the known deployed test fixture; runtime code and every assertion stay intact. */
-export function correctLegacyEmailFixture(source: string): string {
+function correctLegacyEmailFixture(source: string): string {
   return correctKnownFixture(
     source,
     'bf3ec4cd84c85a9e2cd01c7906ca6952dce5d7b957dc38487d6cfe99e9257eed',
@@ -74,7 +74,7 @@ export function correctLegacyEmailFixture(source: string): string {
   );
 }
 
-export function correctLegacyDeployFixture(source: string): string {
+function correctLegacyDeployFixture(source: string): string {
   return correctKnownFixture(
     source,
     'a62cdbc79573bba09da2212c441ebdcec74569d5ec4193d494f54fad98722f33',
@@ -83,7 +83,7 @@ export function correctLegacyDeployFixture(source: string): string {
 }
 
 /** Only the disposable CI database may be used as a template. */
-export function compatibilityTemplate(value: string): URL {
+function compatibilityTemplate(value: string): URL {
   let url: URL;
   try {
     url = new URL(value);
@@ -120,18 +120,14 @@ export function compatibilityTestFiles(root: string): Array<string> {
 }
 
 /** Keep the deployed runtime/tests intact, with one upgraded database snapshot per file. */
-export async function runIsolatedCompatibilityTests(options: {
+async function runIsolatedCompatibilityTests(options: {
   templateUrl: string;
   files: ReadonlyArray<string>;
   query: (statement: string) => Promise<unknown>;
   runTest: (file: string, databaseUrl: string) => Promise<number>;
-  concurrency?: number;
 }): Promise<Array<string>> {
   const template = compatibilityTemplate(options.templateUrl);
-  const concurrency = options.concurrency ?? 2;
-  if (!Number.isInteger(concurrency) || concurrency < 1 || concurrency > 4) {
-    throw new Error('Compatibility concurrency must be between 1 and 4.');
-  }
+  const concurrency = 2;
   if (!options.files.length || new Set(options.files).size !== options.files.length) {
     throw new Error('Compatibility tests must contain unique test files.');
   }

.github/scripts/schema-fixture.mjs

@@ -9,15 +9,15 @@ const PROJECT_MODE_MIGRATION = {
   timestamp: 1790841384175,
 };
 
-export function isProjectModeMigrationApplied(rows) {
+function isProjectModeMigrationApplied(rows) {
   return (
     rows.length === 1 &&
     rows[0].hash === PROJECT_MODE_MIGRATION.hash &&
     String(rows[0].created_at) === String(PROJECT_MODE_MIGRATION.timestamp)
   );
 }
 
-export function assertSchemaFixturePreserved(original, rows, projectModeMigrationApplied = false) {
+function assertSchemaFixturePreserved(original, rows, projectModeMigrationApplied = false) {
   for (const [table, row] of Object.entries(original)) {
     for (const [key, value] of Object.entries(row)) {
       // 0054 deliberately normalizes the obsolete Worker mode to the public
@@ -40,11 +40,11 @@ export function assertSchemaFixturePreserved(original, rows, projectModeMigratio
   }
 }
 
-export async function runSchemaFixture(command, env = process.env) {
+async function runSchemaFixture(command) {
   const snapshot =
-    env.COMPAT_FIXTURE_PATH ??
-    (env.RUNNER_TEMP ? `${env.RUNNER_TEMP}/void-schema-fixture.json` : undefined);
-  if (!snapshot || !env.COMPAT_DATABASE_URL) {
+    process.env.COMPAT_FIXTURE_PATH ??
+    (process.env.RUNNER_TEMP ? `${process.env.RUNNER_TEMP}/void-schema-fixture.json` : undefined);
+  if (!snapshot || !process.env.COMPAT_DATABASE_URL) {
     throw new Error('A disposable compatibility database and fixture path are required.');
   }
   if (command !== 'seed' && command !== 'verify') {
@@ -55,7 +55,7 @@ export async function runSchemaFixture(command, env = process.env) {
   const { Pool } = createRequire(
     pathToFileURL(`${process.cwd()}/platform/packages/api/package.json`),
   )('pg');
-  const pool = new Pool({ connectionString: env.COMPAT_DATABASE_URL });
+  const pool = new Pool({ connectionString: process.env.COMPAT_DATABASE_URL });
   try {
     if (command === 'seed') {
       await pool.query(
@@ -104,6 +104,4 @@ export async function runSchemaFixture(command, env = process.env) {
   }
 }
 
-if (process.argv[1] && pathToFileURL(process.argv[1]).href === import.meta.url) {
-  await runSchemaFixture(process.argv[2]);
-}
+await runSchemaFixture(process.argv[2]);

TESTING.md

@@ -51,9 +51,9 @@ The runner adds coverage that imports cannot describe:
 `--list` does not refresh builds, so built-export coverage can expand when the command executes.
 Affected selection is conservative, not a proof that all behavior is covered: computed imports,
 filesystem reads, generated artifacts, and external services can introduce additional dependencies.
-Explicitly run a known consumer when changing one of those boundaries, and add a selector regression
-when introducing a new fixture layout. Changes to packaging still need the packed checks below;
-changes to metaframework output still need `build:all` and the artifact check.
+Explicitly run a known consumer when changing one of those boundaries. Changes to packaging still
+need the packed checks below; changes to metaframework output still need `build:all` and the
+artifact check.
 
 For a leaf-module edit with known import-based consumers, Vitest's native related command is useful:
 
@@ -143,16 +143,14 @@ repeat those production builds. `vpr test:all` runs the same artifact check loca
 
 Integration sharding uses [measured duration estimates](test/integration-timings.ts), rather than
 filename hashes. [The sequencer](test/sequencer.ts) packs the longest files first and starts costly
-fixtures early. Estimates affect scheduling only: new files receive a fallback estimate, and
-membership tests ensure every discovered file appears exactly once. Refresh the estimates when
-the suite's costs change materially. Seeded file shuffling remains available for isolation checks.
+fixtures early. Estimates affect scheduling only: new files receive a fallback estimate. Refresh
+the estimates when the suite's costs change materially. Seeded file shuffling remains available
+for isolation checks.
 
 The four adapter suites share their client and island test definitions in `test/`. Each runs the
 full browser behavior contract against its production preview build, plus a dev-mode navigation,
 island hydration/interaction smoke check, SSR/protocol assertions, and HMR checks. This keeps both
-runtime modes covered without repeating the full browser matrix. Before integrations start,
-their sources are snapshotted so another test cloning a fixture cannot capture an in-flight HMR
-edit. Dependencies stay linked to the installed workspace, and snapshots are removed afterward.
+runtime modes covered without repeating the full browser matrix.
 
 Use production functions in unit tests. A copy of a hook's implementation inside a test cannot
 catch regressions in the real hook. Shared form-value equality has one direct suite, and actual
@@ -247,8 +245,7 @@ VOID_TEST_BROWSER=webkit vp test run packages/react/test/integration packages/vu
 Use `waitForIslandsHydrated` from `test/browser-helpers.ts` before asserting island state or
 interacting with islands. Pass the expected minimum count when checking a multi-island fixture.
 Each island imports and hydrates independently, so a selector matching one hydrated island does
-not establish that its siblings are ready. The helper rejects empty or partially hydrated pages;
-`packages/void/test/integration/browser-helpers.test.ts` covers these cases.
+not establish that its siblings are ready. The helper rejects empty or partially hydrated pages.
 
 For SPA navigation, wait for a client readiness signal before setting the document marker and
 clicking. The Nuxt and SvelteKit playgrounds expose `h1[data-hydrated="true"]` after client startup.

packages/create-void/src/pm.ts

@@ -4,7 +4,7 @@ import { join } from 'pathslash';
 
 export type PM = 'npm' | 'pnpm' | 'yarn' | 'bun';
 
-export const VOID_PNPM_ALLOWED_BUILDS = ['esbuild', 'sharp', 'workerd'] as const;
+const VOID_PNPM_ALLOWED_BUILDS = ['esbuild', 'sharp', 'workerd'] as const;
 
 /** Write the explicit build-script policy required by a new pnpm project. */
 export function writePnpmBuildPolicy(root: string, pm: PM): void {

packages/create-void/test/unit/pm.test.ts

@@ -2,7 +2,7 @@ import { existsSync, mkdtempSync, readFileSync, rmSync } from 'node:fs';
 import { tmpdir } from 'node:os';
 import { join } from 'node:path';
 import { afterEach, describe, expect, it } from 'vite-plus/test';
-import { VOID_PNPM_ALLOWED_BUILDS, writePnpmBuildPolicy } from '../../src/pm.ts';
+import { writePnpmBuildPolicy } from '../../src/pm.ts';
 
 const temporaryDirectories: Array<string> = [];
 
@@ -20,7 +20,7 @@ describe('create-void package manager bootstrap', () => {
     writePnpmBuildPolicy(root, 'pnpm');
 
     expect(readFileSync(join(root, 'pnpm-workspace.yaml'), 'utf-8')).toBe(
-      `allowBuilds:\n  better-sqlite3: false\n${VOID_PNPM_ALLOWED_BUILDS.map((name) => `  ${name}: true`).join('\n')}\n`,
+      'allowBuilds:\n  better-sqlite3: false\n  esbuild: true\n  sharp: true\n  workerd: true\n',
     );
   });
 
@@ -34,20 +34,4 @@ describe('create-void package manager bootstrap', () => {
       expect(existsSync(join(root, 'pnpm-workspace.yaml'))).toBe(false);
     }
   });
-
-  it('stays aligned with the policy written by void init', () => {
-    const initSource = readFileSync(
-      join(import.meta.dirname, '../../../void/src/cli/init.ts'),
-      'utf-8',
-    );
-    const declaration = initSource.match(
-      /const PNPM_ALLOWED_BUILDS = \[([\s\S]*?)\] as const;/,
-    )?.[1];
-    if (!declaration) {
-      throw new Error('Could not find the void init pnpm build policy.');
-    }
-    const initAllowedBuilds = [...declaration.matchAll(/'([^']+)'/g)].map((match) => match[1]);
-
-    expect(VOID_PNPM_ALLOWED_BUILDS).toEqual(initAllowedBuilds);
-  });
 });

packages/deploy-cloudflare/src/config.ts

@@ -1,5 +1,5 @@
 import { existsSync, readFileSync } from 'node:fs';
-import { parse as parseJsoncConfig, type ParseError } from 'jsonc-parser';
+import { applyEdits, modify, parse as parseJsoncConfig, type ParseError } from 'jsonc-parser';
 
 /** Parse a root Wrangler JSON/JSONC config without accepting a partial parse. */
 export function parseRootWranglerConfig(configPath: string): Record<string, unknown> {
@@ -21,6 +21,14 @@ export function parseRootWranglerConfig(configPath: string): Record<string, unkn
   return parsed as Record<string, unknown>;
 }
 
+/** Set one value in JSONC text, keeping comments and formatting elsewhere. */
+export function setJsoncValue(text: string, path: Array<string>, value: unknown): string {
+  return applyEdits(
+    text,
+    modify(text, path, value, { formattingOptions: { insertSpaces: true, tabSize: 2, eol: '\n' } }),
+  );
+}
+
 export function readWranglerTopLevelString(
   config: Record<string, unknown>,
   field: string,

packages/deploy-cloudflare/src/framework.ts

@@ -1,6 +1,7 @@
 import { existsSync, mkdirSync, readFileSync, writeFileSync } from 'node:fs';
-import { applyEdits, modify, parse } from 'jsonc-parser';
+import { parse } from 'jsonc-parser';
 import { dirname, join, relative } from 'pathslash';
+import { setJsoncValue } from './config.ts';
 
 export type CloudflareFrameworkDeployConfig = Readonly<{
   configPath: string;
@@ -33,12 +34,7 @@ export function writeCloudflareFrameworkDeployConfig(
     : '{}\n';
   let content = initial;
   const upsert = (path: Array<string>, value: unknown): void => {
-    content = applyEdits(
-      content,
-      modify(content, path, value, {
-        formattingOptions: { insertSpaces: true, tabSize: 2, eol: '\n' },
-      }),
-    );
+    content = setJsoncValue(content, path, value);
   };
 
   upsert(['name'], options.name);

packages/deploy-cloudflare/src/static.ts

@@ -1,16 +1,15 @@
 import { cpSync, existsSync, mkdirSync, readFileSync, rmSync, writeFileSync } from 'node:fs';
 import type { AssetConfig, HeaderRule, RedirectRule } from '@void/deploy-core';
 import {
-  applyEdits,
   createScanner,
-  modify,
   parse,
   parseTree,
   type Node,
   type ParseError,
   SyntaxKind,
 } from 'jsonc-parser';
 import { dirname, join, relative, resolve } from 'pathslash';
+import { setJsoncValue } from './config.ts';
 
 export type CloudflareStaticDeployConfig = Readonly<{
   configPath: string;
@@ -100,10 +99,7 @@ export function writeCloudflareStaticDeployConfig(options: CloudflareStaticDeplo
   const originalComments = extractCommentTokens(source);
   let content = source;
   const upsert = (path: Array<string>, value: unknown): void => {
-    const edits = modify(content, path, value, {
-      formattingOptions: { insertSpaces: true, tabSize: 2, eol: '\n' },
-    });
-    content = applyEdits(content, edits);
+    content = setJsoncValue(content, path, value);
   };
 
   upsert(['name'], options.name);