Repository navigation
Use the long temp path in the dev secret guard test on Windows - #397
Merged
Merged
Conversation
The Windows CI temp dir is C:\Users\RUNNER~1\..., an 8.3 short name. Plain realpathSync keeps it, and Vite refuses to serve any file under a short-name path, so /.void/routes.d.ts returned 403 instead of 200. realpathSync.native expands it to the long name. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://fix-dev-secret-guard-windows-temp-root-void-cloud.voidzero-docs.workers.dev (commit 7aa0fe7)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mainCI fails ontest (windows-latest, 2/2)on every push since #384:The test is not flaky. It never passed on Windows. #384 added it, and PRs only run Windows CI with the
test: windowslabel.Cause
Vite 8.3 refuses every file under a short-name path on Windows. This is Vite's own rule. The Void guard is correct: all the 404 cases in the file pass on Windows.
What this PR changes
realpathSync.nativeexpands the short name.plugin-env-schema.tsalready uses it for the same reason, and its tests pass on Windows.Testing
vp test run packages/void/test/integration/dev-trigger-secret-guard.test.ts(macOS)RUNNER~1rootwindows-latestCI on this PR (test: windowslabel)🤖 Generated with Claude Code