Skip to content

Keep NUL bytes out of the build-agent log test output #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Brooooooklyn merged 1 commit into from
Oct 8, 2026
Merged

Keep NUL bytes out of the build-agent log test output #392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions platform/packages/api/test/unit/build-manager.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7174,8 +7174,14 @@ describe('build-agent GET /logs serves post-child-close lines', () => {
// is just under the 2 MiB budget, and the line cap is 2000). Serialized, each
// NUL is `\u0000` — six bytes — so the real body is ~12.6 MB.
const control = '\u0000'.repeat(1048);
for (let i = 0; i < MAX_LOG_RESPONSE_LINES; i++) {
record(control, 'stdout');
// record() mirrors each line to stderr; keep the NUL bytes out of the test output.
const mirror = vi.spyOn(process.stderr, 'write').mockReturnValue(true);
try {
for (let i = 0; i < MAX_LOG_RESPONSE_LINES; i++) {
record(control, 'stdout');
}
} finally {
mirror.mockRestore();
}

server = await startControlServer(0);
Expand Down Expand Up @@ -7735,8 +7741,14 @@ describe('build-agent log buffer is bounded', () => {
const control = '\u0000'.repeat(64 * 1024);
const flood = Math.ceil((MAX_BUFFERED_LOG_BYTES / (control.length * 6)) * 2);
expect(flood).toBeLessThan(MAX_BUFFERED_LOG_LINES);
for (let i = 0; i < flood; i += 1) {
record(control, 'stdout');
// record() mirrors each line to stderr; keep the NUL bytes out of the test output.
const mirror = vi.spyOn(process.stderr, 'write').mockReturnValue(true);
try {
for (let i = 0; i < flood; i += 1) {
record(control, 'stdout');
}
} finally {
mirror.mockRestore();
}

const wire = getBufferedLogLines().reduce(
Expand Down
Loading