Skip to content

Keep affected-test fixture commits independent of Git signing - #388

Merged
Brooooooklyn merged 1 commit into
mainfrom
fix/affected-tests-commit-signing
Oct 8, 2026
Merged

Brooooooklyn merged 1 commit into
mainfrom
fix/affected-tests-commit-signing

Conversation

@Brooooooklyn

@Brooooooklyn Brooooooklyn commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Problem

affected-tests.test.ts makes temporary Git repositories and runs git commit in them. Those commits read the developer's global Git config, so commit signing turns on for them too.

vp test run affected-tests.test.ts
  └─ fixture: git commit
       └─ ~/.gitconfig: commit.gpgsign = true
            └─ signer (e.g. op-ssh-sign) locked or slow
                 ├─ hangs ~60 s per commit, or
                 └─ "fatal: failed to write commit object"
                      └─ 5 of 27 tests fail locally (CI passes: no signing)

Fix

All fixture Git calls now go through one fixtureGit(root) helper. It passes -c commit.gpgsign=false plus a fixed test name and email. Command-line -c wins over both config files and GIT_CONFIG_* env vars. The code under test only runs read-only Git commands, so it does not change.

Testing

Command Before After
GIT_CONFIG_COUNT=3 env forcing commit.gpgsign=true, gpg.format=ssh, gpg.ssh.program=/usr/bin/false + vp test run packages/void/test/unit/affected-tests.test.ts 5 failed, 22 passed 27 passed
GIT_CONFIG_GLOBAL=<file with the same signing setup> + same test file 5 failed, 22 passed 27 passed
vp test run packages/void/test/unit/affected-tests.test.ts not run 27 passed
vp lint / vp fmt --check on the file - clean

🤖 Generated with Claude Code

The fixture repositories ran git commit with the developer's global Git
config. With commit.gpgsign on and a locked or slow signer, those commits
hung or failed and five tests broke locally while CI passed. All fixture
Git calls now go through one helper that turns signing off and sets the identity.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T03:35:12.087284Z b4f3291 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://fix-affected-tests-commit-signing-void-cloud.voidzero-docs.workers.dev (commit b4f3291)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://afe3d9ab-void-cloud.voidzero-docs.workers.dev b4f3291 2026-10-08T03:34:41.929Z Visit the dashboard ↗

@Brooooooklyn
Brooooooklyn merged commit ca39929 into main Oct 8, 2026
20 checks passed
@Brooooooklyn
Brooooooklyn deleted the fix/affected-tests-commit-signing branch October 8, 2026 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant