Repository navigation
Keep affected-test fixture commits independent of Git signing - #388
Merged
Merged
Conversation
The fixture repositories ran git commit with the developer's global Git config. With commit.gpgsign on and a locked or slow signer, those commits hung or failed and five tests broke locally while CI passed. All fixture Git calls now go through one helper that turns signing off and sets the identity. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://fix-affected-tests-commit-signing-void-cloud.voidzero-docs.workers.dev (commit b4f3291)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
affected-tests.test.tsmakes temporary Git repositories and runsgit commitin them. Those commits read the developer's global Git config, so commit signing turns on for them too.Fix
All fixture Git calls now go through one
fixtureGit(root)helper. It passes-c commit.gpgsign=falseplus a fixed test name and email. Command-line-cwins over both config files andGIT_CONFIG_*env vars. The code under test only runs read-only Git commands, so it does not change.Testing
GIT_CONFIG_COUNT=3env forcingcommit.gpgsign=true,gpg.format=ssh,gpg.ssh.program=/usr/bin/false+vp test run packages/void/test/unit/affected-tests.test.tsGIT_CONFIG_GLOBAL=<file with the same signing setup>+ same test filevp test run packages/void/test/unit/affected-tests.test.tsvp lint/vp fmt --checkon the file🤖 Generated with Claude Code