Repository navigation
Run the email clipboard watch test on fake timers - #387
Merged
Merged
Conversation
The clipboard watch ends at a Date.now() deadline (40 ms in this test). Under heavy load the event loop can stall long enough for the deadline to pass before the token poll, so the flow falls back to the paste prompt and the test sees the paste token instead of the clipboard one. Fake timers make the window virtual; the assertions are unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://fix-email-cli-domain-flake-void-cloud.voidzero-docs.workers.dev (commit 48c3784)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The clipboard watch test in
email-cli-domain.test.tssometimes fails when the machine is busy.Fix
The test runs the watch on fake timers and advances time by the watch window, so the 40 ms deadline cannot pass early. The assertions do not change.
afterEachrestores real timers.Testing
vp test run packages/void/test/unit/email-cli-domain.test.tsvp lint,vp fmt --checkon the file🤖 Generated with Claude Code