Repository navigation
fix(platform): return operator session expiry as ISO UTC from confirmation GET - #383
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://fix-operator-session-expiry-iso-void-cloud.voidzero-docs.workers.dev (commit 848282d)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 80e9f864dc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Brooooooklyn
force-pushed
the
fix/operator-session-expiry-iso
branch
2 times, most recently
from
October 7, 2026 14:58
4f7ba3c to
5479b68
Compare
…ation GET
operator_sessions.expires_at is timestamp without time zone; the
string-mode column mapping returns SQL text ('2026-10-07 12:13:32')
while the elevation POST serializes with toISOString(). The iOS admin
gate validates ISO UTC and rejected the confirmation response
(admin-session-confirm incompatibleResponse, status 200).
Parse the timezone-less wall time explicitly as UTC and serialize with
toISOString() so confirmation returns the same instant and the same
text the elevation issued.
Adds a regression test that round-trips the expiry through the real
database conversion and asserts both responses carry byte-identical
ISO text plus the full shape the app validates. Observed: fails on the
old code ('2026-10-07 12:13:32' vs '2026-10-07T12:13:32.000Z'),
passes 8/8 with the fix.
Brooooooklyn
force-pushed
the
fix/operator-session-expiry-iso
branch
from
October 7, 2026 15:00
5479b68 to
848282d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
POST /operator/v1/session(elevation) serializesexpiresAtwithtoISOString()→2026-10-07T12:13:32.000Z.GET /operator/v1/session(confirmation) passed the column value through raw:operator_sessions.expires_atistimestamp without time zone, and the string-mode column mapping returns SQL text2026-10-07 12:13:32— same instant, different text. The iOS admin gate validates ISO UTC and rejected the confirmation response (admin-session-confirm incompatibleResponse, status 200).Fix
In the confirmation handler only: parse the timezone-less wall time explicitly as UTC (
Tseparator,+00:00— no assumed bare suffix, no runtime-local guessing) and serialize withtoISOString(). The response now carries the same instant and the same ISO text the elevation issued. The middleware context value is untouched and nothing else reads it, so blast radius is this one response.Test evidence (observed, not expected)
New regression test round-trips the expiry through the real database conversion (PGlite) and asserts both responses carry byte-identical ISO text plus the full shape the app validates (apiVersion 1, same user, eight capability flags as booleans, hostedWorkerOperations a boolean).
expected '2026-10-07 12:13:32' to be '2026-10-07T12:13:32.000Z'