Repository navigation
Conversation
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://docs-update-main-page-void-cloud.voidzero-docs.workers.dev (commit 71fedd7)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 60edbdeee6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .platform-panel__copy p { | ||
| max-width: 32ch; | ||
| margin-top: 0.65rem; | ||
| color: #777780; |
There was a problem hiding this comment.
The #777780 text has a contrast ratio of only about 4.17:1 against the control panel's #f8f8f6 background, below the 4.5:1 requirement for this 0.85rem normal-weight text. The same color reused for the 0.9rem AI-card paragraphs on white reaches only about 4.44:1, so both newly added sections are difficult to read for low-vision users; use a darker text color for these paragraphs.
Useful? React with 👍 / 👎.
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| if (typeof document !== 'undefined') { | ||
| const preload = document.createElement('link'); | ||
| preload.rel = 'preload'; | ||
| preload.href = heroAnimation; | ||
| preload.as = 'fetch'; | ||
| preload.crossOrigin = 'anonymous'; | ||
| document.head.appendChild(preload); | ||
| } |
There was a problem hiding this comment.
The preload link injection runs every time the component is created and will append duplicate <link> elements to document.head if the component remounts (e.g., during route navigation or hot reload). This causes DOM pollution and potential memory leaks.
Fix: Add a check to prevent duplicates or move this to onMounted with cleanup:
onMounted(() => {
if (!document.querySelector(`link[href="${heroAnimation}"]`)) {
const preload = document.createElement('link');
preload.rel = 'preload';
preload.href = heroAnimation;
preload.as = 'fetch';
preload.crossOrigin = 'anonymous';
document.head.appendChild(preload);
}
});| if (typeof document !== 'undefined') { | |
| const preload = document.createElement('link'); | |
| preload.rel = 'preload'; | |
| preload.href = heroAnimation; | |
| preload.as = 'fetch'; | |
| preload.crossOrigin = 'anonymous'; | |
| document.head.appendChild(preload); | |
| } | |
| onMounted(() => { | |
| if (!document.querySelector(`link[href="${heroAnimation}"]`)) { | |
| const preload = document.createElement('link'); | |
| preload.rel = 'preload'; | |
| preload.href = heroAnimation; | |
| preload.as = 'fetch'; | |
| preload.crossOrigin = 'anonymous'; | |
| document.head.appendChild(preload); | |
| } | |
| }); | |
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
|
I squashed and picked all your changes to main locally, will make minor adjustments before I push later today. Just for the public record, those rive animations are killer. Great work. |
No description provided.