Skip to content

test: Fix inherited PATH fixture on Windows - #343

Merged
cpojer merged 2 commits into
mainfrom
codex/fix-windows-deploy-env-path
Sep 25, 2026
Merged

cpojer merged 2 commits into
mainfrom
codex/fix-windows-deploy-env-path

Conversation

@cpojer

@cpojer cpojer commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Make the deploy environment tests set and restore the inherited path variable regardless of its casing. Windows runners expose it as Path, so writing PATH left the original value in the test fixture.
  • Give the local D1 test that starts a real Wrangler proxy 30 seconds for startup. On the first Windows rerun it exceeded Vitest's five-second default, then cleanup encountered the still-open database.

Verification

  • vp test run packages/void/test/unit/deploy-auth.test.ts (36 passed)
  • vp test run packages/void/test/unit/local-d1.test.ts packages/void/test/unit/deploy-auth.test.ts (43 passed)
  • vp run check (passed)
  • vp test run before the timeout-only follow-up (563 files passed, 10,862 tests passed)
  • Pre-commit formatting and lint checks (passed)

Original failure: run 36092665595. The first Windows rerun exposed the local D1 timeout in run 36093529378. The PR has the test: windows label so the required Windows jobs run before merge.

@cpojer
cpojer enabled auto-merge (squash) September 25, 2026 04:32
@cpojer
cpojer merged commit 644891d into main Sep 25, 2026
30 of 33 checks passed
@cpojer
cpojer deleted the codex/fix-windows-deploy-env-path branch September 25, 2026 04:42
@cpojer
cpojer deployed to cloudflare-e2e September 25, 2026 04:42 — with GitHub Actions Active

This branch was successfully deployed

1 active and 1 inactive deployments
Staging — 644891d1 Deployed Sep 25, 2026 by cpojer via smoke-test / smoke-test #101
cloudflare-e2e — 644891d1 Deployed Sep 25, 2026 by cpojer via live-e2e #1604
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant