Repository navigation
test: Fix inherited PATH fixture on Windows - #343
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Path, so writingPATHleft the original value in the test fixture.Verification
vp test run packages/void/test/unit/deploy-auth.test.ts(36 passed)vp test run packages/void/test/unit/local-d1.test.ts packages/void/test/unit/deploy-auth.test.ts(43 passed)vp run check(passed)vp test runbefore the timeout-only follow-up (563 files passed, 10,862 tests passed)Original failure: run 36092665595. The first Windows rerun exposed the local D1 timeout in run 36093529378. The PR has the
test: windowslabel so the required Windows jobs run before merge.