Skip to content

fix: make permission errors actionable across platform clients - #339

Merged
Brooooooklyn merged 1 commit into
mainfrom
codex/team-permission-ux
Sep 23, 2026
Merged

Brooooooklyn merged 1 commit into
mainfrom
codex/team-permission-ux

Conversation

@Brooooooklyn

Copy link
Copy Markdown
Member

Project permission failures could show raw 403 {"error":"forbidden"} output or lose useful explanations in command-specific handlers. Rejections now explain the required access and a recovery step across the CLI, dashboard, remote bindings, and admin pages.

  • Add human-readable API messages while preserving HTTP statuses, machine error codes, and authorization decisions. Carry the guidance through transaction rechecks, deployment streams, email operations, owner-only actions, and invitation conflicts.
  • Prefer meaningful server messages in clients, provide operation-specific guidance for older APIs, and keep expired credentials, suspension, scoped tokens, GitHub authorization, and project roles distinct. Preserve structured CLI error metadata and stop deployment preflight on explicit authorization rejection.
  • Add safe fallbacks for malformed or HTML responses and recovery navigation for admin rejection pages.

Validation: vpr test:all passed builds, typechecks, formatting, lint, and all 563 test files: 10,840 tests passed, 21 skipped. Regression cases verify reader mutation denials, owner-only token operations, access revoked during operations, and unchanged state after rejected writes. Local verification used a fresh kitchen-sink D1 test database and temporarily excluded an obsolete ignored scratch fixture; both original fixtures were restored.

Production deployment and package publication are separate from this PR's local validation.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-22T18:27:04.562580Z 6023e3b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Brooooooklyn
Brooooooklyn merged commit 8a2ad6c into main Sep 23, 2026
19 checks passed
@Brooooooklyn
Brooooooklyn deleted the codex/team-permission-ux branch September 23, 2026 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant