Skip to content

fix(platform): address project team acceptance regressions - #336

Merged
Brooooooklyn merged 1 commit into
mainfrom
codex/fix-project-team-acceptance
Sep 22, 2026
Merged

Brooooooklyn merged 1 commit into
mainfrom
codex/fix-project-team-acceptance

Conversation

@Brooooooklyn

Copy link
Copy Markdown
Member

Project deletion could remain stuck in deleting when AI Analytics was unavailable. Invitation commands could also contact an old linked platform, the landing page gave unsupported relinking instructions, and expired invitation renewals could exceed the pending-invitation cap. This fixes the acceptance regressions found after #328.

Changes

  • Persist the detached ownership window, last usage sample, and retry alarm atomically so deletion and transfer can finish during Analytics outages. Reconcile later, retain useful provider errors, and handle billing rollover and deleted accounts.
  • Resolve account-scoped invitation commands against the selected platform with origin-bound credentials. Preserve existing project links and explain the supported onboarding flow.
  • Enforce the 100-live-invitation cap for creation, refresh, and resend under the project lock.
  • Show project roles, reject reader deployment targets before building, and provide recovery commands for failed invitation email delivery and invalid invitations.
  • Add regression coverage and update collaboration documentation.

Validation

  • Core build, repository formatting/lint, platform type-aware lint, and all 28 tracked workspace type checks passed.
  • Complete platform suite with a fresh UTC database cache: 4,247 passed, 15 PostgreSQL-gated tests skipped.
  • Isolated PostgreSQL 17.11: 210 passed, zero skipped, including all 15 gated cases and invitation concurrency. Test server shutdown verified.
  • Broad SDK/platform run: 10,622 passed; four assertions and one suite setup initially failed. Two assertions came from a cached database timezone mismatch, two required the new project-list preflight in the deployment mock, and kitchen-sink setup had stale local D1 migration history. The complete platform rerun, updated deployment integration (3/3), and fresh-D1 kitchen-sink rerun (27/27) passed. The broad suite was not rerun in its entirety afterward.
  • Canonical vp run check remains blocked by an unrelated ignored scratch app missing its TypeScript compiler dependency; tracked workspace checks pass.

Staging follow-up

These changes have not been deployed. Live multi-account invitation/role journeys, operator ownership transfer, and cleanup of the disposable staging QA project remain pending. The underlying provider-side Analytics failure still needs staging diagnosis; it no longer blocks deletion in the covered regression.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-22T15:36:05.307339Z b45c80a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Brooooooklyn
Brooooooklyn merged commit ab849b0 into main Sep 22, 2026
19 checks passed
@Brooooooklyn
Brooooooklyn deleted the codex/fix-project-team-acceptance branch September 22, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant