Repository navigation
tests: Fix flaky Vue HMR test. - #33
Merged
Merged
Conversation
Brooooooklyn
approved these changes
Mar 26, 2026
cpojer
added a commit
that referenced
this pull request
Mar 26, 2026
cpojer
pushed a commit
that referenced
this pull request
Sep 11, 2026
Add MAX_SECRET_NAME_LENGTH (256) and MAX_SECRET_VALUE_BYTES (128KB) hard limits. Value size check uses TextEncoder for correct byte measurement. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk: adds straightforward request validation for the secrets PUT endpoint plus integration coverage; main risk is rejecting previously-accepted oversized inputs. > > **Overview** > Adds hard limits for project secrets: `MAX_SECRET_NAME_LENGTH` (256 chars) and `MAX_SECRET_VALUE_BYTES` (128KB), and enforces them in `PUT /:id/secrets/:name` (byte size measured via `TextEncoder`). > > Introduces integration tests to ensure overlong secret names and oversized secret values return `400` with the expected error messages. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit da7080df9ef9e129e602f2b1817b20e75cb8e28e. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test tends to be flaky on CI. This PR changes it to explicitly wait for HMR being ready, which should make it less flaky.