Repository navigation
test: Fix flaky email-domain and OAuth checks - #329
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The email-domain list test treated
_ivanywhere in the response as a secret leak, so the valid generated IDedom_ivm16k7p54l5failed staging CI. Check the six encrypted-secret properties directly, retain the plaintext-token assertion, and pin the failing ID as regression coverage.Full verification also reproduced OAuth test timeouts caused by HTTP keep-alive connections reaching an earlier grant's callback server on the fixed port. Give loopback test requests
Connection: closeso each request reaches the current grant. All 12 OAuth tests now finish in under a second instead of timing out.Validation: reproduced both failures before their fixes; all 87 email-domain integration tests and all 12 OAuth unit tests pass.
vp run test:allpasses formatting, lint, all builds, typechecks, and the complete suite: 508 test files, 10,279 tests passed, 11 skipped.