Repository navigation
test(provision): retry scratch-dir removal after a killed child on Windows - #324
Closed
Brooooooklyn wants to merge 1 commit into
Closed
Brooooooklyn wants to merge 1 commit into
Brooooooklyn wants to merge 1 commit into
Conversation
…ndows
`test (windows-latest, unit)` on main `2bae6708` failed in
`provision-runner-signals.test.ts` — "normal close confirms the whole
GROUP": the assertions passed, then `afterEach` `rmSync('.tmp-group-close')`
threw `EPERM`. The directory is the cwd of the spawned leader and
grandchild. On Windows `TerminateProcess` returns before the dead process
releases its handles, so an immediate `rmSync` races that release.
`removeProcessScratchDir` passes `maxRetries: 10, retryDelay: 100`, which
makes Node retry `EPERM`/`EBUSY`/`ENOTEMPTY` with linear backoff. The
three describes that spawn a real wrangler stand-in inside a scratch cwd
(`.tmp-timeout-kill`, `.tmp-signal-teardown`, `.tmp-group-close`) use it
in both `beforeEach` and `afterEach`. Test bodies are unchanged.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SStP281NuirMSouULEE2pW
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_474b136f-607b-4a50-a029-8c2d7aeccf1a) |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
test (windows-latest, unit)on main2bae6708failed inprovision-runner-signals.test.ts→ "normal close confirms the whole GROUP" (run 35048960102). The assertions passed;afterEachthen threw:Why
The scratch directory is the cwd of the spawned leader and grandchild. On Windows
TerminateProcessreturns before the dead process releases its handles, so an immediatermSyncraces that release.Fix
removeProcessScratchDir(dir)=rmSync(dir, { recursive: true, force: true, maxRetries: 10, retryDelay: 100 }). Node retriesEPERM/EBUSY/ENOTEMPTYwith linear backoff whenmaxRetriesis set. Used inbeforeEach/afterEachof the three describes that spawn a real wrangler stand-in inside a scratch cwd (.tmp-timeout-kill,.tmp-signal-teardown,.tmp-group-close). Test bodies are unchanged.Local (macOS):
vp fmt --check/vp lint/ typecheck 0,provision-runner-signals.test.ts14/14. The Windows proof is this PR's CI.🤖 Generated with Claude Code
https://claude.ai/code/session_01SStP281NuirMSouULEE2pW
Note
Low Risk
Test-only teardown change with no production or runtime behavior impact.
Overview
Fixes flaky Windows unit teardown in provision runner tests where
afterEachcould fail withEPERMwhile deleting scratch dirs used as spawned processcwd.Adds
removeProcessScratchDir, which deletes viarmSyncwithmaxRetries: 10andretryDelay: 100so Node retriesEPERM/EBUSY/ENOTEMPTYuntil handles are released afterTerminateProcess.beforeEach/afterEachin the three describes that spawn real wrangler stand-ins (hard timeout kill, parent-signal teardown, group-close) now use this helper instead of immediate recursivermSync; test assertions are unchanged.Reviewed by Cursor Bugbot for commit e06f1de. Bugbot is set up for automated code reviews on this repo. Configure here.