Repository navigation
test: harden Windows CI readiness checks - #321
Conversation
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_f13ef433-69c0-4fd1-ac1a-690dc5dad7e6) |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Limit concurrent integration tests to two per file on Windows while retaining file parallelism. Capture a bounded, read-only memory and TCP snapshot on the first test failure per file without masking the original error. Add reporter regression coverage and document the policy.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_66abef75-5749-413d-b080-39f5ee14612f) |
Summary
Harden the tests behind the intermittent Windows failures in the main CI run.
TESTING.md.Failure evidence
Verification
Completed locally on macOS:
vp run build:allvp run checkvp lintandvp run lint:platformvp fmt --checkvp test run: 7,496 passed across 373 files; six credentialed live E2E tests skipped.git diff --checkWindows confirmation remains pending CI. The
test: windowslabel enables the Windows matrix for this PR.Note
Low Risk
Changes are limited to test helpers, CI config, playground test signals, and documentation; no production auth or deploy logic is modified.
Overview
Hardens browser integration tests and Windows CI against flaky readiness and resource pressure, without changing product runtime behavior beyond test playground markers.
Island and SPA readiness: Adds shared
waitForIslandsHydrated(minimum island count + alldata-hydrated="true") and replaces per-frameworkwaitForSelector/ inline waits in React, Vue, Svelte, and Solid client tests. Adds a Playwright regression for empty, under-count, and partially hydrated pages. Nuxt/SvelteKit home pages exposeh1[data-hydrated="true"]after client boot; navigation tests wait on that instead ofnetworkidle, keep full-reload markers, and attachcollectBrowserDiagnosticsplus bounded dev-server stdout/stderr on failure. Dev startup uses stricterwaitForServerchecks (status, body, child alive) and longer Windows hook budgets for Nuxt.Windows CI tooling: Parallel integration on Windows gets
maxConcurrency: 2and a setup hook that logs a single shared, bounded PowerShell resource snapshot on first failure per file (memory, processes, TCP). Drizzle deploy-drift subprocess tests get a suite-local timeout (30s Windows / 10s elsewhere). Documents these conventions inTESTING.md.Reviewed by Cursor Bugbot for commit 89a5f93. Bugbot is set up for automated code reviews on this repo. Configure here.