Repository navigation
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 62647ec4e8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Deferring to @TheAlexLichter who built this. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b662c6c8ea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
As a note: because the false validation warning shows up on log, it is very confusing for AI agents. codex got mixed up in loops with the viteconf repo |
|
Part of this was no longer relevant, the other part was fixed on main. |
Framework class B/C owns env loading. Some frameworks copy .env.local values into process.env before Void validates them. Void currently removes the copied shell values, causing false missing-variable warnings during development. The fix snapshots process.env before framework loading so it can distinguish original shell variables from values added later by the framework.
EDIT: also updated to properly handle class A frameworks
ViteConf repo (astro): void would always warn about missing env... even though variables existed.
