Skip to content

refactor(void): change pages server scan from regex to ast - #305

Closed
mdong1909 wants to merge 2 commits into
mainfrom
fix-void-ignore-commented-out-actions
Closed

mdong1909 wants to merge 2 commits into
mainfrom
fix-void-ignore-commented-out-actions

Conversation

@mdong1909

Copy link
Copy Markdown
Contributor

Fixes: #304

Currently pages scan uses regex. This doesn't differentiate commented out code.
Updates to use AST for server files

Downside is it add 2ms per file, which is negligible for most repos

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 23da912921

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/void/src/pages/scan.ts Outdated
@mdong1909
mdong1909 requested a review from Brooooooklyn August 30, 2026 03:56
@Brooooooklyn

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-08-30T13:33:52.557216Z 7ae390e Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: 7ae390eca4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@cpojer cpojer closed this in 834239e Sep 30, 2026
@cpojer

cpojer commented Sep 30, 2026

Copy link
Copy Markdown
Member

Fixed on main, no more negative perf impact.

@cpojer
cpojer deleted the fix-void-ignore-commented-out-actions branch October 3, 2026 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Commented out action & actions still triggers error

3 participants