Repository navigation
feat(playground): make named-layouts visually easier to identify #296
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,20 @@ | ||
| export default function LandingLayout({ children }: { children: React.ReactNode }) { | ||
| return ( | ||
| <div data-layout="landing" style={{ minHeight: '100vh', margin: -8 }}> | ||
| <header | ||
| style={{ | ||
| boxSizing: 'border-box', | ||
| width: '100%', | ||
| padding: '16px 24px', | ||
| background: '#305CDE', | ||
| color: '#ffffff', | ||
| fontWeight: 700, | ||
| textAlign: 'center', | ||
| }} | ||
| > | ||
| Landing | ||
| </header> | ||
| <main style={{ padding: 16 }}>{children}</main> | ||
| </div> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,20 @@ | ||
| export default function ApiLayout({ children }: { children: React.ReactNode }) { | ||
| return ( | ||
| <div data-layout="api" style={{ minHeight: '100vh', margin: -8 }}> | ||
| <header | ||
| style={{ | ||
| boxSizing: 'border-box', | ||
| width: '100%', | ||
| padding: '16px 24px', | ||
| background: '#006400', | ||
| color: '#ffffff', | ||
| fontWeight: 700, | ||
| textAlign: 'center', | ||
| }} | ||
| > | ||
| API | ||
| </header> | ||
| <main style={{ padding: 16 }}>{children}</main> | ||
| </div> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,20 @@ | ||
| export default function DocsLayout({ children }: { children: React.ReactNode }) { | ||
| return ( | ||
| <div data-layout="docs" style={{ minHeight: '100vh', margin: -8 }}> | ||
| <header | ||
| style={{ | ||
| boxSizing: 'border-box', | ||
| width: '100%', | ||
| padding: '16px 24px', | ||
| background: '#FFCE1B', | ||
| color: '#ffffff', | ||
| fontWeight: 700, | ||
| textAlign: 'center', | ||
| }} | ||
| > | ||
| Docs | ||
| </header> | ||
| <main style={{ padding: 16 }}>{children}</main> | ||
| </div> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,20 @@ | ||
| export default function RootLayout({ children }: { children: React.ReactNode }) { | ||
| return ( | ||
| <div data-layout="root" style={{ minHeight: '100vh', margin: -8 }}> | ||
| <header | ||
| style={{ | ||
| boxSizing: 'border-box', | ||
| width: '100%', | ||
| padding: '16px 24px', | ||
| background: '#dc2626', | ||
| color: '#ffffff', | ||
| fontWeight: 700, | ||
| textAlign: 'center', | ||
| }} | ||
| > | ||
| Layout | ||
| </header> | ||
| <main style={{ padding: 16 }}>{children}</main> | ||
|
There was a problem hiding this comment.
On Useful? React with 👍 / 👎. |
||
| </div> | ||
| ); | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On
/docs, the default 16px white label against#FFCE1Bhas a contrast ratio of approximately 1.49:1, far below the 4.5:1 threshold for normal-sized text. This makes the newly added layout identifier difficult to read for low-vision users and undermines the purpose of making layouts visually distinguishable; use substantially darker text or a darker background.Useful? React with 👍 / 👎.